Unused imported modules in generated opt file

Bug #1498122 reported by Kendall Nelson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
High
Kendall Nelson

Bug Description

The following modules were being imported in the auto-generated opts.py file, but no opt lists were being added to the sections from them

cinder/api/middleware/auth - use_forwarded_for cinder.api.middleware.sizelimit , osapi_max_request_body_size
cinder/cmd - backend_host (deprectated)
cinder/db/base: db_driver
cinder/scheduler/manager: scheduler_driver cinder.scheduler.scheduler_options , scheduler_json_config_location
cinder/volume/api : allow_force_upload, volume_host_opt, volume_same_az_opt, az_cache_time_opt

Changed in cinder:
assignee: nobody → Kendall Nelson (kjnelson)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/225974

Changed in cinder:
status: New → In Progress
Jay Bryant (jsbryant)
Changed in cinder:
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/225974
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=10f5e92e1246dd33b244c4a7031bb81b17b240a3
Submitter: Jenkins
Branch: master

commit 10f5e92e1246dd33b244c4a7031bb81b17b240a3
Author: Kendall Nelson <email address hidden>
Date: Mon Sep 21 13:11:19 2015 -0500

    Missing configuration opts from cinder.sample.conf

    The logic for writing opts registered with register_opt() to the
    auto-generated opts.py file was flawed in that the directories where
    there were opts being registered with this method would be imported,
    but the actual opt would be missed when looking through the file for
    the name of the opt being registered. Now the singular opts are being
    caught and written to opts.py for the oslo-config-generator to process.

    The 'backend' section was added to generate_cinder_opts.py
    due to some of the missing opts being a part of that section.

    Also the way some of the opts that were being registered with groups
    were incorrect and so this addresses those in both how they were
    processed in generate_cinder_opts.py and the files in which they are being
    registered.

    There is also one change to the name of an opt in cinder/volume/api.py.
    Instances such as this one will be caught by the in-progress hacking
    check patch: https://review.openstack.org/#/c/223375/

    Change-Id: I8d333d7529d40f3a3b3651ca3a52c0048d96b99a
    Closes-Bug: #1498122

Changed in cinder:
status: In Progress → Fix Committed
Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/cinder 8.0.0.0b1

This issue was fixed in the openstack/cinder 8.0.0.0b1 development milestone.

Thierry Carrez (ttx)
Changed in cinder:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.