volume ref in VolumeDriver replication_failover and list_replication_targets are missing 'name' property

[Patrick East]

We noticed that the volume reference passed in to

def list_replication_targets(self, context, vref):

and

def replication_failover(self, context, volume, secondary):

does not seem to have the 'name' property available.

I think this is a side effect of the way we are getting the volume properties in the admin_actions API for these two methods and then passing the dictionary back down to the drivers.

This is a problem for drivers that depend on using the volume['name'] for naming of underlying volumes on a backend.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/219874

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/219874
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=01ff9d7dc7af54eaa218ef86839b0468de283c7e
Submitter: Jenkins
Branch: master

commit 01ff9d7dc7af54eaa218ef86839b0468de283c7e
Author: Patrick East <email address hidden>
Date: Wed Sep 2 13:51:42 2015 -0700

    Get full volume model in Replication manager API’s

    Currently we pass in a dictionary of the volume properties, but not the
    actual volume model. This dictionary is missing some of the properties
    like ‘name’ which backends may required for volume operations.

    Change-Id: Idcb7b2c8313360a77ba336f3b7534d8fa7431a41
    Closes-Bug: #1491585