The SVC volume driver is not using all the FC ports for zonig

[Gerald McBrearty]

The SVC volume driver is using the svcinfo lsnode command to determine the FC ports to use.
The svcnifo lsnode command only reports the first 4 wwpns. On an SVC with more than 4 FC ports on a node
the svcinfo lsportfc command will reports all of the FC ports.

What we are seeing is that only the first 4 ports on each node are used instead of all of them.

[Jay Bryant (jsbryant)]

Gerald, you are planning to fix this? That would be awesome! I am going to target this for Liberty. Let me know if we can help.

[Gerald McBrearty (gfm-r)]

Jay, yea we need it now so I thought I'd fix it

[Jay Bryant (jsbryant)]

Wanted to share this note from Xiao Qin related to this bug:

Hi, Jay

After I checked with SVC team, the lsnode exactly only contains four FC ports. So we should fix it in storwise cinder. But only after the end of September :).

See the svc comments in svc code:

/* The FC WWPN feature is superseded by lsportfc. But for compatibility
* we maintain 4 FC ports in the lsnode full view.
*
* Try to use the FC IO port, but if there isn't one then use the old
* VPD field - this covers nodes running code < 640 and nodes running
* code >= 640 but with < 4 FC ports.
*/

/* for each port 1 - 4, get their wwpn and status from node vpd */

BTW, According to the Redbook, there are four FC ports in Storwise, but for svc , there can be more than four. But four fc ports are basic and general configure.

-------------------------------------

The note about September is because she isn't working on Storwize full time until that point. Since you are working this Gerald that won't be an issue.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/219973

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/219973
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=fff85444da2a87c6ac2be17459c35a08f41f1c25
Submitter: Jenkins
Branch: master

commit fff85444da2a87c6ac2be17459c35a08f41f1c25
Author: Gerald McBrearty <email address hidden>
Date: Wed Sep 2 22:08:54 2015 -0500

    Switch SVC driver to use lsportfc to determine FC target WWPNS

    Switched the startup code within SVC driver to use the
    SVC lsportfc command rather than the lsnode command to determine the
    target WWPNs for an SVC node, and updated SVC testcases.
    The SVC lsportfc command returns all of the FC ports so that
    all of the FC ports can be zoned and thus utilized by
    the VM that a volume is attached to.
    Where the lsnode command is documented to only report the
    first 4 FC ports.

    Closes-Bug: 1490041

    Change-Id: I6acac0080a96a5b3dfbc6fb8b54a456206b21688