Barbarism of editing a file

Bug #1487665 reported by JuPing
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
JuPing

Bug Description

There are some barbarism located in the file cinder/HACKING.rst.
    line11 and line21 : there is no full point at the end of a sentence.
    line14 and line23 : after a sentence, there are two space between the full point and the first letter of the second sentence.
I think the correct format of the above question as blow:
   - [N319] Validate that debug level logs are not translated.
   - [C302] six.text_type should be used instead of unicode.
   - [N325] str() and unicode() cannot be used on an exception. Remove or use six.text_type().
   - [C304] Enforce no use of LOG.audit messages. LOG.info should be used instead.

JuPing (jup-fnst)
Changed in cinder:
assignee: nobody → JuPing (jup-fnst)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/215885

Changed in cinder:
status: New → In Progress
summary: - Barbarism of editting a file
+ Barbarism of editing a file
JuPing (jup-fnst)
information type: Public → Public Security
Revision history for this message
Jeremy Stanley (fungi) wrote :

It looks like you switched this to a security bug (indicating a suspected exploitable vulnerability) by mistake. I have switched this back to a regular public bug now.

information type: Public Security → Public
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/216942

JuPing (jup-fnst)
Changed in cinder:
status: In Progress → Incomplete
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/215885
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=a69d5fffb58405ed07440cbcbb9262c3dcc18ecc
Submitter: Jenkins
Branch: master

commit a69d5fffb58405ed07440cbcbb9262c3dcc18ecc
Author: JuPing <email address hidden>
Date: Sat Aug 22 07:45:47 2015 +0000

    Fix description for "Barbarism of editting a file"

    There are some barbarism located in the file cinder/HACKING.rst.
      line11 and line21 : there is no full point at the end of a sentence.
      line14 and line23 : after a sentence, there are two space between
      the full point and the first letter of the second sentence.
    I think the correct format of the above question as blow.
       - [N319] Validate that debug level logs are not translated.
       - [C302] six.text_type should be used instead of unicode.
       - [N325] str() and unicode() cannot be used on
       an exception. Remove or use six.text_type().
       - [C304] Enforce no use of LOG.audit
       messages. LOG.info should be used instead.

    Change-Id: I2896bacc5379786ed115d47e520bf5bc2af0028a
    Closes-Bug: #1487665

Changed in cinder:
status: Incomplete → Fix Committed
Thierry Carrez (ttx)
Changed in cinder:
milestone: none → liberty-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: liberty-rc1 → 7.0.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on cinder (master)

Change abandoned by Sean McGinnis (<email address hidden>) on branch: master
Review: https://review.openstack.org/216942
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.