Inability to remove name or description from volume type

[Joel Coffman]

The SQLAlchemy volume_type_update function (http://git.openstack.org/cgit/openstack/cinder/tree/cinder/db/sqlalchemy/api.py#n2294) has several issues:
1. possible key errors if 'name' and 'description' are not in the values dictionary passed as a parameter,
2. the inability to remove an existing name or description, and
3. retrieving the updated data without first flushing the session.
In practice, the first issue is currently guarded against via checks in other modules so the values dictionary always contains 'name' and 'description' keys, but the second issue effectively precludes removing an existing name or description, which should be possible.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/219007

[OpenStack Infra (hudson-openstack)]

Change abandoned by Sean McGinnis (<email address hidden>) on branch: master
Review: https://review.openstack.org/213829
Reason: This review is > 4 weeks without comment and currently blocked by a core reviewer with a -2. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and contacting the reviewer with the -2 on this review to ensure you address their concerns.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Joel Coffman (<email address hidden>) on branch: master
Review: https://review.openstack.org/213829

[OpenStack Infra (hudson-openstack)]

Change abandoned by Joel Coffman (<email address hidden>) on branch: master
Review: https://review.openstack.org/219007

[Sean McGinnis (sean-mcginnis)]

Unassigning due to no activity for > 6 months.