Multiple record for same user and resource in quota_usage table

[Zhenyu Zheng]

Currently, the quota usage table doesn't contain UniqueConstraint policy. Although it has locks when writing data, but under extreme circumstance, for example: launching over 100 instances at the same time for a new tenant(user). In this condition,the quota usage table for this user is empty, and there might be a chance that multiple record are recorded for same resource and same user.

Adding UniqueConstraint policy for this table can solve this problem.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/217465

[OpenStack Infra (hudson-openstack)]

Change abandoned by Zhenyu Zheng (<email address hidden>) on branch: master
Review: https://review.openstack.org/212908
Reason: Need to come up with new ideas.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Sean McGinnis (<email address hidden>) on branch: master
Review: https://review.openstack.org/217465
Reason: This review is > 4 weeks without comment and currently blocked by a core reviewer with a -2. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and contacting the reviewer with the -2 on this review to ensure you address their concerns.

[John Garbutt (johngarbutt)]

Seems like a very good idea.

Given the use of first, I suspect that caused issues where we just update one copy, and leave the other. Not sure if the order is always deterministic.

Just need to be sure to clean out duplicates, I think it's safe to delete the one we would not access using first. Need this in the script before adding the constraint, similar to what has been done for uuid constraints previously.

[Zhenyu Zheng (zhengzhenyu)]

@John Garbutt, thanks for the information, the clean up thing was actually what blocked this, could you provide more details about the example you talked about?

[surbhi sarda (surbhisarda)]

@Zhenyu Zheng Can i work on this bug?

[Jay Bryant (jsbryant)]

This hasn't been touched for quite some time. I think it can be moved to triaged. Someone else could pick it up.

[Sean McGinnis (sean-mcginnis)]

Unassigning due to no activity for > 6 months.

[Matt Riedemann (mriedem)]

Nova hasn't used the quota usages table since Pike:

https://specs.openstack.org/openstack/nova-specs/specs/pike/implemented/cells-count-resources-to-check-quota-in-api.html

[Gorka Eguileor (gorka)]

Proposed patch: https://review.opendev.org/c/openstack/cinder/+/779946

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 18.0.0.0rc2 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 19.0.0.0b1 development milestone.