AttributeError: 'NfsDriver' object has no attribute 'retype'

[Eric Harney]

It's bug 1471807 part 2.

4ba9-bc29-f3dd5f6aee04'] from (pid=13125) reserve /opt/stack/cinder/cinder/quota.py:800
2015-07-28 10:07:35.682 ERROR cinder.volume.manager [req-79d9b721-e2a8-4965-a5d0-6378cb1960e7 None None] Volume 96b1719c-3bd4-4076-b0e2-1db11cfbd88f: driver error when tryin
g to retype, falling back to generic mechanism.
2015-07-28 10:07:35.682 TRACE cinder.volume.manager Traceback (most recent call last):
2015-07-28 10:07:35.682 TRACE cinder.volume.manager File "/opt/stack/cinder/cinder/volume/manager.py", line 1719, in retype
2015-07-28 10:07:35.682 TRACE cinder.volume.manager ret = self.driver.retype(context,
2015-07-28 10:07:35.682 TRACE cinder.volume.manager AttributeError: 'NfsDriver' object has no attribute 'retype'
2015-07-28 10:07:35.682 TRACE cinder.volume.manager

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/206559

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/206559
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=0eb3014195a3e300e6179296c2cfabfa4e785821
Submitter: Jenkins
Branch: master

commit 0eb3014195a3e300e6179296c2cfabfa4e785821
Author: Eric Harney <email address hidden>
Date: Tue Jul 28 10:19:07 2015 -0400

    Remove RetypeVD class, fix NFS driver retype

    retype() only exists in the deprecated VolumeDriver() class
    and not BaseVD. This means that drivers inheriting from *VD
    hit attribute errors when trying to call driver.retype().

    The thinking here is that RetypeVD isn't really necessary,
    since all drivers must implement some version of the retype
    method (even if it's a no-op with just a standard return code).

    Therefore, just rely on this being in the base driver class(es)
    rather than making it a separate abc class.

    Closes-Bug: #1478987
    Related-Bug: #1471807

    Change-Id: Ie0c6f23caf68080a05a10cc7ad245878a057fb02

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/221425

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/221445

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/221425
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=223fbd36b7ec433040f5b95dcbaacf46f6939b79
Submitter: Jenkins
Branch: master

commit 223fbd36b7ec433040f5b95dcbaacf46f6939b79
Author: Eric Harney <email address hidden>
Date: Tue Sep 8 13:31:31 2015 -0400

    Add migrate_volume to BaseVD

    migrate_volume() only exists in the deprecated VolumeDriver()
    class and not BaseVD. This means that drivers inheriting from
    *VD hit attribute errors when trying to call driver.migrate_volume().

    I suspect this indicates that we should rework some of our
    abc class structure a little bit, but this seems like a
    reasonable fix for now.

    Related-Bug: #1478987
    Related-Bug: #1471807
    Closes-Bug: #1493286

    Change-Id: I3d555507416606db265b8ebe335b51a08fe32328

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/221445
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=7edc87ff0e92043f5a21d630bbb9b966f5e34535
Submitter: Jenkins
Branch: master

commit 7edc87ff0e92043f5a21d630bbb9b966f5e34535
Author: Eric Harney <email address hidden>
Date: Tue Sep 8 14:10:55 2015 -0400

    Add manage_existing and unmanage to BaseVD

    manage_existing() and unmanage() only exist in the deprecated
    VolumeDriver() class and not BaseVD. This means that drivers
    inheriting from *VD hit attribute errors when trying to call
    either of these methods.

    Related-Bug: #1478987
    Related-Bug: #1493286
    Related-Bug: #1471807
    Closes-Bug: #1487329

    Change-Id: Ie8aba971b51e1f5eaac5a4e681ea06b358ebb7b8