Shred is not using ionice

Bug #1477805 reported by Christoph Dwertmann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Low
Unassigned

Bug Description

The comment in cinder.conf says:

# The flag to pass to ionice to alter the i/o priority of the
# process used to zero a volume after deletion, for example
# "-c3" for idle only priority. (string value)
#volume_clear_ionice=<None>

However looking at the code, it seems that shred is not invoked with ionice:
https://github.com/openstack/cinder/blob/master/cinder/volume/utils.py#L381

It would be great to have since shred can cause severe IO load.

Changed in cinder:
importance: Undecided → Low
tags: added: low-hanging-fruit
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/396755

Changed in cinder:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/396755
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=f90c49e0062c4e9287b44e11040fa16a26013a58
Submitter: Jenkins
Branch: master

commit f90c49e0062c4e9287b44e11040fa16a26013a58
Author: Sean McGinnis <email address hidden>
Date: Fri Nov 11 13:49:24 2016 -0600

    Remove deprecated volume_clear shred option

    This option was deprecated in the Newton release and has
    performed the same action as the zero option.

    Change-Id: I473636595fb6696f426565a2f14ebe7070afa560
    Closes-bug: #1477805

Changed in cinder:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/cinder 10.0.0.0b2

This issue was fixed in the openstack/cinder 10.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.