Many policies incorrectly have empty policy settings

Bug #1477621 reported by Jay Bryant
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
Ivan Kolodyazhny

Bug Description

In the process of addressing bug https://launchpad.net/bugs/1475422 we discovered that empty ("") policy settings were not behaving as expected. I think we expected that it would use the default policy, but in actuality it just sets the policy so that anyone can use it.

We need to go through /etc/cinder/policy.json and update many (or all) of the policies to use rule:admin_or_owner .

Changed in cinder:
assignee: nobody → Ivan Kolodyazhny (e0ne)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/219231
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=e065e70a69b1b6de1bd383cb471dbab62b93e03a
Submitter: Jenkins
Branch: master

commit e065e70a69b1b6de1bd383cb471dbab62b93e03a
Author: Ivan Kolodyazhny <email address hidden>
Date: Tue Sep 1 14:00:06 2015 +0300

    Remove empty rules from policies for API access

    Empty policy rule means that API method is allowed by anybody. Default rule
    is used only if such rule is not defined in policy.json.

    This patch changes empty rules to admin_api or admin_or_owner.

    Closes-Bug: #1477621
    Closes-Bug: #1491495
    Change-Id: I512e65e62da7dab5834a21ef9fd967ed6e9bb695

Changed in cinder:
status: In Progress → Fix Committed
Ivan Kolodyazhny (e0ne)
Changed in cinder:
milestone: none → liberty-rc1
Thierry Carrez (ttx)
Changed in cinder:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: liberty-rc1 → 7.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.