Remove unused context parameter from cinder methods

Bug #1458844 reported by Abhijeet Malawade
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Low
Abhijeet Malawade

Bug Description

In cinder there are many methods which are not using context parameter at all.

ex.-
1. '_translate_snapshot_summary_view' method: https://github.com/openstack/cinder/blob/master/cinder/api/v2/snapshots.py#L44
2. 'service_version' and 'service_config' methods:
https://github.com/openstack/cinder/blob/master/cinder/manager.py#L106
3. '_add_volume_mig_status_attribute' method:
https://github.com/openstack/cinder/blob/master/cinder/api/contrib/volume_mig_status_attribute.py#L25
4. '_add_volume_tenant_attribute' method:
https://github.com/openstack/cinder/blob/master/cinder/api/contrib/volume_tenant_attribute.py#L25
5. '_add_replication_attributes' method:
https://github.com/openstack/cinder/blob/master/cinder/api/contrib/volume_replication.py#L42

So the context parameter should be removed from all of these Methods.

Changed in cinder:
assignee: nobody → Abhijeet Malawade (abhijeet-malawade)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/185861

Changed in cinder:
status: New → In Progress
Jay Bryant (jsbryant)
Changed in cinder:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/185861
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=a5f3ef577818302d701c97ac2e4d42c34bdda0b5
Submitter: Jenkins
Branch: master

commit a5f3ef577818302d701c97ac2e4d42c34bdda0b5
Author: Abhijeet Malawade <email address hidden>
Date: Tue May 26 06:58:00 2015 -0700

    Remove unused context parameter

    Context parameter is removed from cinder methods
    which are not using it at all.

    Removed 'notification' method from volume/manager.py as it is
    not getting used anywhere.

    Change-Id: I2ecfdabb876485ac0c0d1cacd6778408be061fc8
    Closes-Bug: #1458844

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in cinder:
milestone: none → liberty-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: liberty-3 → 7.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.