IBM drivers needs to return snapshot objects for create_cgsnapshot and delete_cgsnapshot

Bug #1458128 reported by Thang Pham
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Medium
Xinli Guan

Bug Description

This bug is a placeholder to have IBM drivers return snapshot objects instead of snapshot dictionaries for create_cgsnapshot and delete_cgsnapshot methods. It was noted on a review comment in https://review.openstack.org/#/c/163910/14//COMMIT_MSG. These drivers include:

- ibm/xiv_ds8k.py
- ibm/gpfs.py
- ibm/storwize_svc/__init__.py

This can be done be replacing occurences of db.snapshot_get_all_for_cgsnapshot() to SnapshotList.get_all_for_cgsnapshot() in create_cgsnapshot and delete_cgsnapshot. It is dependent on https://review.openstack.org/#/c/163910/.

Xing Yang (xing-yang)
Changed in cinder:
status: New → Triaged
importance: Undecided → Medium
assignee: nobody → TaoBai (baitao2020)
Thang Pham (thang-pham)
description: updated
Thang Pham (thang-pham)
description: updated
Revision history for this message
Sean McGinnis (sean-mcginnis) wrote :

Automatically unassigning due to inactivity.

Changed in cinder:
assignee: TaoBai (baitao2020) → nobody
Ryan McNair (rdmcnair)
Changed in cinder:
assignee: nobody → Ryan McNair (rdmcnair)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/268283

Changed in cinder:
status: Triaged → In Progress
Revision history for this message
Xinli Guan (xinli-v) wrote :

After discussion with Ryan in Austin summit/2016, Ray wants to assign this bug to me and continue working under his guidance (mentor program).

Changed in cinder:
assignee: Ryan McNair (rdmcnair) → Xinli Guan (xinli-v)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/268283
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=bf2be3ddb6f9c716288c70bc7fb37c229e911788
Submitter: Jenkins
Branch: master

commit bf2be3ddb6f9c716288c70bc7fb37c229e911788
Author: Ryan McNair <email address hidden>
Date: Fri Jan 15 18:22:30 2016 +0000

    Make IBM drivers return snapshot object for cg ops

    Update the IBM drivers to return snapshot objects (instead of dicts)
    for create_cgsnapshot and delete_cgsnapshot. Also use the snapshot
    list param passed in instead of re-querying for snapshots. Any code
    that was already being touched was fixed up to use the Snapshot/Volume
    objects (instead of dicts) as well.

    The test scenarios use objects, test_gpfs needs to use valid UUIDs
    instead of simple string such as "cg-1234" or "123456"

    Co-Authored-By: Xinli Guan <email address hidden>

    Change-Id: I826811dfdf209fab91d16dc03decfca3993500a5
    Closes-Bug: #1458128

Changed in cinder:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/cinder 9.0.0.0b1

This issue was fixed in the openstack/cinder 9.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.