EMC drivers needs to return snapshot objects for create_cgsnapshot and delete_cgsnapshot

[Thang Pham]

This bug is a placeholder to have EMC drivers return snapshot objects instead of snapshot dictionaries for create_cgsnapshot and delete_cgsnapshot methods. It was noted on a review comment in https://review.openstack.org/#/c/163910/14//COMMIT_MSG. These drivers include:

- emc/emc_cli_fc.py
- emc/emc_cli_iscsi.py
- emc/emc_vmax_fc.py
- emc/emc_vmax_iscsi.py
- emc/emc_vnx_cli.py

For VMAX, this can be done be replacing occurences of db.snapshot_get_all_for_cgsnapshot() with SnapshotList.get_all_for_cgsnapshot() -https://github.com/openstack/cinder/blob/master/cinder/volume/drivers/emc/emc_vmax_utils.py#L1512. I am not sure about VNX because I do not see how it returns snapshots. In any case, it is dependent on https://review.openstack.org/#/c/163910/.

[Xing Yang (xing-yang)]

Example here:

https://github.com/openstack/cinder/blob/master/cinder/volume/drivers/prophetstor/dplcommon.py#L924

[Xing Yang (xing-yang)]

Patch for the prophetstor change:
https://review.openstack.org/#/c/185495/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/209835

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/209835
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=562e0c54db4cb7737fc0bdf974e34d6c72be063e
Submitter: Jenkins
Branch: master

commit 562e0c54db4cb7737fc0bdf974e34d6c72be063e
Author: Tina <email address hidden>
Date: Wed Aug 5 22:04:29 2015 -0400

    VNX driver needs to return snapshot objects

    Use snapshot objects instead of snapshot dictionaries of
    create_cgsnapshot and delete_cgsnapshot.

    Change-Id: I0794e1c30a1ef8f0a4bdf82c6cb850ae4415d164
    Partially-Closes-Bug: #1458125

[Sean McGinnis (sean-mcginnis)]

Unassigning due to no activity.