Cinder doesn't correctly handle None values in set quota

Bug #1451637 reported by Jamie Lennox
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Triaged
Undecided
Unassigned

Bug Description

Prior to openstackclient 1.1.0 when you did a quota set it would send None values to cinder for options it didn't want to change. Cinder would reject this change with a generic 400 bad client response.

There are two parts to this:

1. Cinder should return an appropriate error like it does when you try to set a non-integer value to a quota.
2. Should cinder ignore None values in a quota set?

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/180003

Changed in cinder:
assignee: nobody → Jamie Lennox (jamielennox)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/180003
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=f3630dd130d6e2e90b84416c9084e515604718ed
Submitter: Jenkins
Branch: master

commit f3630dd130d6e2e90b84416c9084e515604718ed
Author: Jamie Lennox <email address hidden>
Date: Tue May 5 11:50:21 2015 +1000

    Catch additional type conversion errors

    When converting strings to integers in quota we catch ValueError which
    will handle an input which is not a valid number, eg 'abc'. Extend this
    to covert TypeErrors which will handle things like a None value being
    passed.

    Partial-Bug: #1451637
    Change-Id: I7e3e694d539113beeb99001aeb80012ac4c1124d

Revision history for this message
Sean McGinnis (sean-mcginnis) wrote :

Automatically unassigning due to inactivity.

Changed in cinder:
assignee: Jamie Lennox (jamielennox) → nobody
status: In Progress → Triaged
Changed in cinder:
assignee: nobody → Karthik Prabhu Vinod (karthik-prabhu-vinod)
Changed in cinder:
assignee: Karthik Prabhu Vinod (karthik-prabhu-vinod) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.