oslo-config-generator does not work with new oslo namespaces

Bug #1449235 reported by Jay Bryant
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Critical
Jay Bryant
oslo.config
Invalid
Undecided
Unassigned

Bug Description

We have discovered in Cinder that the config generator does not work with oslo_concurrency instead of oslo.concurrency:

jsbryant@ubuntu-14-04:~$ oslo-config-generator --namespace oslo_concurrency
[DEFAULT]
jsbryant@ubuntu-14-04:~$ oslo-config-generator --namespace oslo.concurrency
[DEFAULT]

[oslo_concurrency]

#
# From oslo.concurrency
#

# Enables or disables inter-process locks. (boolean value)
# Deprecated group/name - [DEFAULT]/disable_process_locking
#disable_process_locking = false

# Directory to use for lock files. For security, the specified
# directory should only be writable by the user running the processes
# that need locking. Defaults to environment variable OSLO_LOCK_PATH.
# If external locks are used, a lock path must be set. (string value)
# Deprecated group/name - [DEFAULT]/lock_path
#lock_path = <None>
jsbryant@ubuntu-14-04:~$

Jay Bryant (jsbryant)
Changed in cinder:
importance: Undecided → Critical
assignee: nobody → Jay Bryant (jsbryant)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/177957

Changed in cinder:
status: New → In Progress
Revision history for this message
Doug Hellmann (doug-hellmann) wrote :

The entry point namespace if the name of the library, not the name of the python package. So using "oslo.concurrency" is the correct form.

Changed in oslo.config:
status: New → Invalid
Revision history for this message
Doug Hellmann (doug-hellmann) wrote :

s/if the name/is the name/

Revision history for this message
Jay Bryant (jsbryant) wrote :

That seems kind-of inconsistent, but I won't worry about trying to fix oslo-config-generator if that is the way it is supposed to work.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote :

The code isn't using that value to do a direct import, it's looking for an entry point name. We opted to name the entry points after the library so they would be consistently named.

Revision history for this message
Sean McGinnis (sean-mcginnis) wrote :

Jay, I believe this is fixed. Can you confirm?

Changed in cinder:
milestone: none → mitaka-1
Revision history for this message
Jay Bryant (jsbryant) wrote :

Yes, this looks like it is fixed. We are getting options from oslo_concurrency in the generated config file.

Changed in cinder:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.