Missing qos_specs_id for volume type show

Bug #1438488 reported by Liyingjun
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Wishlist
Nate Potter

Bug Description

qos_specs_id is not returned for volume type show [1], we should add this to make it convenience to get qos specs associated to the volume type.

[1]: http://developer.openstack.org/api-ref-blockstorage-v2.html

Liyingjun (liyingjun)
Changed in cinder:
assignee: nobody → Liyingjun (liyingjun)
Revision history for this message
John Griffith (john-griffith) wrote :

Probably would be a good thing to look at adding, but I'd argue it's an enhancement/improvement as opposed to a bug. Would you agree?

Changed in cinder:
status: New → Opinion
importance: Undecided → Wishlist
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/169153

Changed in cinder:
status: Opinion → In Progress
Revision history for this message
Liyingjun (liyingjun) wrote :

Yes, it's an improvement. Do i need to file a bp for this? it just a few lines change.

Revision history for this message
John Griffith (john-griffith) wrote :

@Liyingjun
Oh cool! You already proposed a change for it, that's great!! No, in my opinion this doesn't need a bp. The only thing I'm likely going to comment on in the review is backporting it to V1. We typically don't do that with features/enhancements particularly since we've deprecated V1.

Thanks a lot for submitting this!!

Revision history for this message
Huang Zhiteng (zhiteng-huang) wrote :

We should take care of this bug first: https://bugs.launchpad.net/cinder/+bug/1351971 before expose even more behind-the-scene details, which deployer would most want to hide, to non-admin users.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on cinder (master)

Change abandoned by Mike Perez (<email address hidden>) on branch: master
Review: https://review.openstack.org/169153
Reason: Over a month with no update.

Mike Perez (thingee)
Changed in cinder:
status: In Progress → Triaged
assignee: Liyingjun (liyingjun) → nobody
Changed in cinder:
assignee: nobody → Deepti Ramakrishna (dramakri)
Eric Harney (eharney)
Changed in cinder:
assignee: Deepti Ramakrishna (dramakri) → nobody
Nate Potter (ntpttr)
Changed in cinder:
assignee: nobody → Nate Potter (ntpttr)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/234414

Changed in cinder:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/234414
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=b2e92b85b5ea2fc4058d6c0f6e9e3fddc2a9036e
Submitter: Jenkins
Branch: master

commit b2e92b85b5ea2fc4058d6c0f6e9e3fddc2a9036e
Author: Nate Potter <email address hidden>
Date: Tue Oct 13 19:53:23 2015 +0000

    Add qos_specs_id to volume type show

    Adding qos_specs_id to the output of volume
    type show to make getting the qos specs for
    a volume type more convenient. However, this
    variable will only be visible when type show
    is called with the admin role.

    APIImpact
    Change-Id: Id8a2333267c9a51b36c6adfbd142dcc4fbe4f090
    Closes-Bug: #1438488

Changed in cinder:
status: In Progress → Fix Committed
Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/cinder 8.0.0.0b1

This issue was fixed in the openstack/cinder 8.0.0.0b1 development milestone.

Thierry Carrez (ttx)
Changed in cinder:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.