vmware driver accesses volume['instance_uuid']

[Walt Boring]

The vmware/vmdk.py file incorrectly accesses columns in the volume object that no longer exist.

def copy_volume_to_image():

        if volume['instance_uuid'] or volume['attached_host']:
            msg = _("Upload to glance of attached volume is not supported.")
            LOG.error(msg)
            raise exception.InvalidVolume(msg)

instance_uuid and attached_host no longer live in the volume object, but volume_attachments object.

[Walt Boring (walter-boring)]

volume['volume_attachment'] will be a list if there are any attachments made.

[Mike Perez (thingee)]

Did their CI catch this?

[Walt Boring (walter-boring)]

I think that some 3rd party CI is skipping the volume upload tests. I just found this by grepping.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/167884

[Vipin Balachandran (vbala)]

Test test_volume_upload was added to exclude list due to bug 1237338. It's a mistake that it was not enabled after the fix.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/167884
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=5fdada85969ca770db60892e2c4f67d917efa0d5
Submitter: Jenkins
Branch: master

commit 5fdada85969ca770db60892e2c4f67d917efa0d5
Author: Walter A. Boring IV <email address hidden>
Date: Thu Mar 26 05:09:59 2015 +0000

    VMware: Fixed usage of volume instance_uuid

    instance_uuid and attached_host no longer exist in the volume object.
    They have been moved into the volume_attachment list attachments.

    This patch now tests for non-empty volume_attachment list instead of
    testing the existence of a non None value of instance_uuid.

    Change-Id: I04c46dc49849fb1e0abf955dcc6d7ec1ce5e57a5
    Closes-Bug: 1436603