Volume Manager threw DetachedInstanceError: Parent instance <VolumeAttachment at > is not bound to a Session Error

[Tina Tang]

When we try to retype an attached volume which is in 'in-use' status, in case of the retyping needs to migrate the volume to another volume backend, below Exception was thrown in _migrate_volume_generic method in cinder/volume/manager.py:

4501 2015-03-16 21:24:00.977 128599 ERROR oslo_messaging.rpc.dispatcher [-] Exception during message handling: Parent instance <VolumeAttachment at 0x7f49b11a9ad0> is not bound to a Session; lazy load operation of attribute 'volume' cannot proceed
4502 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher Traceback (most recent call last):
4503 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher File "/usr/local/lib/python2.7/dist-packages/oslo_messaging/rpc/dispatcher.py", line 142, in _dispat ch_and_reply
4504 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher executor_callback))
4505 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher File "/usr/local/lib/python2.7/dist-packages/oslo_messaging/rpc/dispatcher.py", line 186, in _dispat ch
4506 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher executor_callback)
4507 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher File "/usr/local/lib/python2.7/dist-packages/oslo_messaging/rpc/dispatcher.py", line 130, in _do_dis patch
4508 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher result = func(ctxt, **new_args)
4509 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher File "/usr/local/lib/python2.7/dist-packages/osprofiler/profiler.py", line 105, in wrapper
4510 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher return f(*args, **kwargs)
4511 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher File "/usr/local/lib/python2.7/dist-packages/osprofiler/profiler.py", line 105, in wrapper
4512 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher return f(*args, **kwargs)
4513 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher File "/usr/local/lib/python2.7/dist-packages/osprofiler/profiler.py", line 105, in wrapper
4514 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher return f(*args, **kwargs)
4515 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher File "/usr/local/lib/python2.7/dist-packages/osprofiler/profiler.py", line 105, in wrapper
4516 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher return f(*args, **kwargs)
4517 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher File "/usr/local/lib/python2.7/dist-packages/osprofiler/profiler.py", line 105, in wrapper
4518 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher return f(*args, **kwargs)
4519 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher File "/opt/stack/cinder/cinder/volume/manager.py", line 1674, in retype
4520 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher new_reservations, status_update)
4521 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher File "/usr/local/lib/python2.7/dist-packages/oslo_utils/excutils.py", line 85, in __exit__
4522 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher six.reraise(self.type_, self.value, self.tb)
4523 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher File "/opt/stack/cinder/cinder/volume/manager.py", line 1670, in retype
4524 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher new_type_id=new_type_id)
4525 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher File "/usr/local/lib/python2.7/dist-packages/osprofiler/profiler.py", line 105, in wrapper
4526 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher return f(*args, **kwargs)
4527 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher File "/usr/local/lib/python2.7/dist-packages/osprofiler/profiler.py", line 105, in wrapper
4528 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher return f(*args, **kwargs)
4529 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher File "/usr/local/lib/python2.7/dist-packages/osprofiler/profiler.py", line 105, in wrapper
4530 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher return f(*args, **kwargs)
4531 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher File "/usr/local/lib/python2.7/dist-packages/osprofiler/profiler.py", line 105, in wrapper
4532 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher return f(*args, **kwargs)
4533 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher File "/usr/local/lib/python2.7/dist-packages/osprofiler/profiler.py", line 105, in wrapper
4534 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher return f(*args, **kwargs)
4535 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher File "/opt/stack/cinder/cinder/volume/manager.py", line 1395, in migrate_volume
4536 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher self.db.volume_update(ctxt, volume_ref['id'], updates)
4537 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher File "/usr/local/lib/python2.7/dist-packages/oslo_utils/excutils.py", line 85, in __exit__
4538 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher six.reraise(self.type_, self.value, self.tb)
4539 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher File "/opt/stack/cinder/cinder/volume/manager.py", line 1380, in migrate_volume
4540 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher new_type_id)
4541 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher File "/opt/stack/cinder/cinder/volume/manager.py", line 1175, in _migrate_volume_generic
4542 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher new_volume = self.db.volume_create(ctxt, new_vol_values)
4543 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher File "/opt/stack/cinder/cinder/db/api.py", line 169, in volume_create
4544 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher return IMPL.volume_create(context, values)
4545 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher File "/opt/stack/cinder/cinder/db/sqlalchemy/api.py", line 181, in wrapper
4546 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher return f(*args, **kwargs)
4547 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher File "/opt/stack/cinder/cinder/db/sqlalchemy/api.py", line 1044, in volume_create
4548 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher volume_ref.update(values)
4549 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher File "/usr/local/lib/python2.7/dist-packages/oslo_db/sqlalchemy/models.py", line 86, in update
4550 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher setattr(self, k, v)
4551 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/orm/attributes.py", line 226, in __set__
4552 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher instance_dict(instance), value, None)
4553 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/orm/attributes.py", line 1009, in set
4554 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher lambda adapter, i: adapter.adapt_like_to_iterable(i))
4555 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/orm/attributes.py", line 1044, in _set_itera ble
4556 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher collections.bulk_replace(new_values, old_collection, new_collection)
4557 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/orm/collections.py", line 800, in bulk_repla ce
4558 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher new_adapter.append_with_event(member)
4559 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/orm/collections.py", line 663, in append_wit h_event
4560 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher self._data()._sa_appender(item, _sa_initiator=initiator)
4561 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/orm/collections.py", line 1057, in append
4562 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher item = __set(self, item, _sa_initiator)
4563 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/orm/collections.py", line 1029, in __set
4564 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher item = executor.fire_append_event(item, _sa_initiator)
4565 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/orm/collections.py", line 726, in fire_appen d_event
4566 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher item, initiator)
4567 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/orm/attributes.py", line 929, in fire_append _event
4568 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher value = fn(state, value, initiator or self._append_token)
4569 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/orm/attributes.py", line 1169, in emit_backr ef_from_collection_append_event
4570 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher passive=PASSIVE_NO_FETCH)
4571 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/orm/attributes.py", line 616, in append
4572 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher self.set(state, dict_, value, initiator, passive=passive)
4573 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/orm/attributes.py", line 788, in set
4574 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher state, dict_, passive=PASSIVE_ONLY_PERSISTENT | NO_AUTOFLUSH)
4575 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/orm/attributes.py", line 591, in get
4576 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher value = self.callable_(state, passive)
4577 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/orm/strategies.py", line 508, in _load_for_state
4578 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher (orm_util.state_str(state), self.key)
4579 2015-03-16 21:24:00.977 128599 TRACE oslo_messaging.rpc.dispatcher DetachedInstanceError: Parent instance <VolumeAttachment at 0x7f49b11a9ad0> is not bound to a Session; lazy load operation of attribute 'volume' cannot proceed

cinder-manage version list:
2015.1

[Tina Tang (tina-tang)]

We also see this exception when migrate an attached volume.

[Tina Tang (tina-tang)]

Another Exception was seen sometimes during migration an attached volume as well. Add the bug here as cross reference:

https://bugs.launchpad.net/bugs/1434007

[Vincent Hou (houshengbo)]

Thank you for reporting issues about migration. I will take a look and come back.

[Vincent Hou (houshengbo)]

Tina, could you tell which back-ends are you using and from which back-end to which one? Recently I have been testing the retyping and migrating for a while. If it allows the user to retype and transfer the volume content from one back-end to another one, there is going to be a lot combinations that we can do and verify, since cinder supports both iscsi and FC, back-ends ranging from open source storage to enterprise storage.
Are we supposed to support them all? This is really something we need to reconsider.

[Tina Tang (tina-tang)]

Hi Vincent,

When we saw this issue it was migrating a volume from a EMC VNX iSCSI backend to a EMC VNX FC backend. Let me try to migrate a volume between iSCSI backends, and get it back to you soon.

Are you seeing any clue that this may be a backend or protocol specific issue?

Thanks,
Tina

[Tina Tang (tina-tang)]

This is also seen when migrate a volume between EMC VNX iSCSI backends when force-host-copy is set true.

[Xing Yang (xing-yang)]

If this is happening on non-EMC backend, we should remove "emc" and "vnx" from the tags.

[Tina Tang (tina-tang)]

Thanks Xing, Per the comment in bug https://bugs.launchpad.net/bugs/1434007.

This error is seen in backends other than VNX as well. Remove the tags: vnx, emc

[Vincent Hou (houshengbo)]

I have verified that this bug is raised for LVMs, so it is not driver specific, but a general issue.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/167134

[Vincent Hou (houshengbo)]

Folks, I had one patch submitted for it.
The fix is easy IMO, but finding the reason took me a while.

[Tina Tang (tina-tang)]

Hi Vincent,

Thanks very much for resolving this issue. Your fix resolved my issue.

Thanks,
Tina

[neetish bhat (neetishbhat)]

Hey , I updated the code in my openstack with the patch Vincent submitted , I'm still facing the same issue :/ , Tina could you give me some insight into how you got it working ?

[Tina Tang (tina-tang)]

Hi Neetish,

 I didn't do anything special, just patch the code and restarted the cinder volume service. And after that, I am able to migrate an attached volume with --force-host-copy set to True.

Thanks,
Tina

[neetish bhat (neetishbhat)]

Hey thanks for the reply Tina , I patched the code and also restarted the cinder volume serivce thorugh screen , I didn't it try with the --force-host-copy option though , did volume migration when attached to an instance work for you without the option --force-host-copy ?

Thanks ,
Neetish

[Mitsuhiro Tanino (mitsuhiro-tanino)]

Hi Vincent,

I tried your patch and the patch solved the migration problem. Thanks,
Waiting for your further investigation of this issue.

Test environment & steps

$ cinder service-list
+------------------+--------------------+------+---------+-------+----------------------------+-----------------+
| Binary | Host | Zone | Status | State | Updated_at | Disabled Reason |
+------------------+--------------------+------+---------+-------+----------------------------+-----------------+
| cinder-backup | host1 | nova | enabled | down | 2015-03-18T19:28:18.000000 | - |
| cinder-scheduler | host1 | nova | enabled | up | 2015-03-25T15:40:36.000000 | - |
| cinder-volume | host2@lvmdriver-2 | nova | enabled | up | 2015-03-25T15:40:41.000000 | - |
| cinder-volume | host1@lvmdriver-1 | nova | enabled | up | 2015-03-25T15:40:44.000000 | - |
+------------------+--------------------+------+---------+-------+----------------------------+-----------------+

Env:
  2 x c-vol nodes(apply your patch for both nodes).
  Both backends use lioadm of LVM driver.

  [lvmdriver-1]
  iscsi_helper = lioadm
  volume_group = stack-volumes-lvmdriver-1
  volume_driver = cinder.volume.drivers.lvm.LVMVolumeDriver
  volume_backend_name = lvmdriver-1

  [lvmdriver-2]
  iscsi_helper = lioadm
  volume_group = stack-volumes-lvmdriver-2
  volume_driver = cinder.volume.drivers.lvm.LVMVolumeDriver
  volume_backend_name = lvmdriver-1

Steps:
1. Create a volume(The volume was created on host1@lvmdriver-1)
2. Attach a volume to a nova instance
3. Migrate a volume from host1@lvmdriver-1 to host2@lvmdriver-1
   $ cinder migrate vol1 host2@lvmdriver-2#lvmdriver-1

And then, the volume migration was succeeded.

Thanks,

[Vincent Hou (houshengbo)]

Thanks for the verifications, guys.
I guess I need to add some new test cases to the patch.

[neetish bhat (neetishbhat)]

I'm still facing the samw issue , care to help ? :|

[Vincent Hou (houshengbo)]

Have u tried https://review.openstack.org/#/c/167134/?

[neetish bhat (neetishbhat)]

Hey Vincent , I tried with the latest patch 16 , it gave me this error http://pastebin.com/BeJGAtSp , please have a look at it :) Kindly help .

[Vincent Hou (houshengbo)]

Neetish, could you paste the error here? I cannot access the link above.

[neetish bhat (neetishbhat)]

Hey Vincent below is the error log .

    from (pid=24998) create_iscsi_target /opt/stack/cinder/cinder/volume/targets/tgt.py:246
    2015-03-30 13:11:07.634 DEBUG oslo_concurrency.processutils [-] Running cmd (subprocess): sudo cinder-rootwrap /etc/cinder/rootwrap.conf tgt-admin --show from (pid=24998) execute /usr/local/lib/python2.7/dist-packages/oslo_concurrency/processutils.py:199
    2015-03-30 13:11:07.784 DEBUG oslo_concurrency.processutils [-] CMD "sudo cinder-rootwrap /etc/cinder/rootwrap.conf tgt-admin --show" returned: 0 in 0.150s from (pid=24998) execute /usr/local/lib/python2.7/dist-packages/oslo_concurrency/processutils.py:225
    2015-03-30 13:11:07.786 DEBUG oslo_concurrency.processutils [-] Running cmd (subprocess): sudo cinder-rootwrap /etc/cinder/rootwrap.conf tgt-admin --show from (pid=24998) execute /usr/local/lib/python2.7/dist-packages/oslo_concurrency/processutils.py:199
    2015-03-30 13:11:07.983 DEBUG oslo_concurrency.processutils [-] CMD "sudo cinder-rootwrap /etc/cinder/rootwrap.conf tgt-admin --show" returned: 0 in 0.197s from (pid=24998) execute /usr/local/lib/python2.7/dist-packages/oslo_concurrency/processutils.py:225
    2015-03-30 13:11:07.984 DEBUG cinder.volume.targets.iscsi [-] Set provider_location to: 10.10.126.40:3260,3 iqn.2010-10.org.openstack:volume-f4135704-58fe-40b1-b533-d49ed4720a69 1 from (pid=24998) create_export /opt/stack/cinder/cinder/volume/targets/iscsi.py:213
    2015-03-30 13:11:08.094 ERROR oslo_messaging.rpc.dispatcher [-] Exception during message handling: Object '<Volume at 0x7f5cd9a91450>' is already attached to session '330' (this is '332')
    2015-03-30 13:11:08.094 TRACE oslo_messaging.rpc.dispatcher Traceback (most recent call last):
    2015-03-30 13:11:08.094 TRACE oslo_messaging.rpc.dispatcher File "/usr/local/lib/python2.7/dist-packages/oslo_messaging/rpc/dispatcher.py", line 142, in _dispatch_and_reply
    2015-03-30 13:11:08.094 TRACE oslo_messaging.rpc.dispatcher executor_callback))
    2015-03-30 13:11:08.094 TRACE oslo_messaging.rpc.dispatcher File "/usr/local/lib/python2.7/dist-packages/oslo_messaging/rpc/dispatcher.py", line 186, in _dispatch
    2015-03-30 13:11:08.094 TRACE oslo_messaging.rpc.dispatcher executor_callback)
    2015-03-30 13:11:08.094 TRACE oslo_messaging.rpc.dispatcher File "/usr/local/lib/python2.7/dist-packages/oslo_messaging/rpc/dispatcher.py", line 130, in _do_dispatch
    2015-03-30 13:11:08.094 TRACE oslo_messaging.rpc.dispatcher result = func(ctxt, **new_args)
    2015-03-30 13:11:08.094 TRACE oslo_messaging.rpc.dispatcher File "/usr/local/lib/python2.7/dist-packages/osprofiler/profiler.py", line 105, in wrapper
    2015-03-30 13:11:08.094 TRACE oslo_messaging.rpc.dispatcher return f(*args, **kwargs)
    2015-03-30 13:11:08.094 TRACE oslo_messaging.rpc.dispatcher File "/opt/stack/cinder/cinder/volume/manager.py", line 1411, in migrate_volume
    2015-03-30 13:11:08.094 TRACE oslo_messaging.rpc.dispatcher self.db.volume_update(ctxt, volume_ref['id'], updates)
    2015-03-30 13:11:08.094 TRACE oslo_messaging.rpc.dispatcher File "/usr/local/lib/python2.7/dist-packages/oslo_utils/excutils.py", line 85, in __e...

[Vincent Hou (houshengbo)]

I suggest you clean up and restart all the services.

I met this issue before, and it shows up alternatively with the error initially reported in this bug.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/167134
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=f7eb9bd06b153817f0424219165619f0092d4894
Submitter: Jenkins
Branch: master

commit f7eb9bd06b153817f0424219165619f0092d4894
Author: Vincent Hou <email address hidden>
Date: Tue Mar 24 16:30:13 2015 +0800

    Set volume_attachment to [] for the temporary volume creation

    A new table volume_attachment has been added recently. During the
    creation of the temporary volume in migration, the attribute
    volume_attachment is not empty if an attached volume is going to be
    migrated, because all the properties are simply copied.
    This non-empty attribute volume_attachment leads to the failure of
    the volume creation. This patch removes this attribute before the
    temporary volume creation.

    Besides, detach the volume should consider multi-attach as well by
    adding the attachment id parameter.

    Change-Id: I7c2f69945ee8d72b2dba4e68a91b872207df5310
    Closes-bug: #1433019