wsgi unit tests require binding to port 4444

Bug #1421759 reported by Eric Harney
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Low
Eric Harney
OpenStack Compute (nova)
Fix Released
Low
Eric Harney

Bug Description

Unit tests for wsgi fail if port 4444 is used by another process. The test trying to use port 4444 (test_server_pool_waitall) does not require a specific port, so letting it choose an unused port via port 0 would be ideal.

Tags: tests
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/155849

Changed in cinder:
assignee: nobody → Eric Harney (eharney)
status: New → In Progress
Eric Harney (eharney)
Changed in cinder:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/155850

Changed in nova:
assignee: nobody → Eric Harney (eharney)
status: New → In Progress
Jay Pipes (jaypipes)
Changed in nova:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/155850
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=f0831197d4d1ec47263231ad152a455209864c03
Submitter: Jenkins
Branch: master

commit f0831197d4d1ec47263231ad152a455209864c03
Author: Eric Harney <email address hidden>
Date: Fri Feb 13 13:15:53 2015 -0500

    Tests: Don't require binding to port 4444

    If some other process is listening on port 4444,
    test_server_pool_waitall will fail with:

    error: [Errno 98] Address already in use

    This test doesn't require use of this specific port,
    so let it pick an unused port to avoid this failure.

    Closes-Bug: #1421759

    Change-Id: Ib92797e41a2bd37a59d3465b4764f00c1d9c2444

Changed in nova:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/155849
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=8b0d47e7156563e0b64afcf3aa1b95f1f177d334
Submitter: Jenkins
Branch: master

commit 8b0d47e7156563e0b64afcf3aa1b95f1f177d334
Author: Eric Harney <email address hidden>
Date: Fri Feb 13 13:07:46 2015 -0500

    Tests: Don't require binding to port 4444

    If some other process is listening on port 4444,
    test_server_pool_waitall will fail with:

    RuntimeError: Could not bind to 127.0.0.1:4444 after
    trying for 30 seconds

    This test doesn't require use of this specific port,
    so let it pick an unused port to avoid this failure.

    Closes-Bug: #1421759

    Change-Id: I7e6d6f574cd2bbb2fa067001bba4b09b5204a5e1

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → kilo-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: none → kilo-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: kilo-3 → 2015.1.0
Thierry Carrez (ttx)
Changed in cinder:
milestone: kilo-3 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.