Unit tests for LIO and ISER target drivers are horribly written
Bug #1420009 reported by
John Griffith
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Cinder |
Fix Released
|
Medium
|
Anton Arefiev |
Bug Description
The unit tests for iser and lio take a lazy approach and just inherit from the tgtAdm test and rerun with LIO driver entries. This is great in order to get wide/broad coverage and interaction with the TgtAdm driver that's used by iser and lio; but defeats the point of a unit test.
It also means that any time a change is made in the Tgt code and unit test that it has a direct impact on the LIO and ISER tests, even though the change has absolutely NO relation to the ISER or LIO drivers.
These tests should be decoupled, as they are now they're just slightly better than useless.
Changed in cinder: | |
assignee: | nobody → Anton Arefiev (aarefiev) |
Changed in cinder: | |
milestone: | none → liberty-1 |
status: | Confirmed → In Progress |
Changed in cinder: | |
status: | Fix Committed → Fix Released |
Changed in cinder: | |
milestone: | liberty-1 → 7.0.0 |
To post a comment you must log in.
This patch decoupled LIO test cases from tgt.
https:/ /review. openstack. org/#/c/ 148038/