cinder hacking checks don't cover logging format string arg count
Bug #1415241 reported by
Duncan Thomas
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Cinder |
Fix Released
|
Undecided
|
Derrick Wippler |
Bug Description
For example:
LOG.debug("Volume %s caught fire and is at %d degrees C and climbing", (v[name], v[temp]))
The above is easy to code by accident, and the error is trivially recognisable by static analysis (this is done for you by python for %), so hacking should look for it.
A good candidate for the global hacking checks, but a cinder local version is a good start
tags: | added: low-hanging-fruit |
tags: | added: hacking |
tags: |
added: hacking-checks removed: hacking |
Changed in cinder: | |
assignee: | nobody → Scott DAngelo (scott-dangelo) |
Changed in cinder: | |
milestone: | none → liberty-rc1 |
status: | Fix Committed → Fix Released |
Changed in cinder: | |
milestone: | liberty-rc1 → 7.0.0 |
To post a comment you must log in.
Fix proposed to branch: master /review. openstack. org/220246
Review: https:/