EqualLogic driver is ignoring the ssh retries on timeout

Bug #1412940 reported by Rajini Karthik on 2015-01-20
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Undecided
Rajini Karthik

Bug Description

This bug fix merged recently https://review.openstack.org/#/c/147070/ has introduced a new issue.

When the ssh session is timing out, the driver is supposed to make attempts to retry. Depends on the parameter eqlx_cli_max_retries. But it is only trying once.

It is raising the exception on a single attempt. I don't see the error message "SSH Command failed after x number of attempts" in the logs.

Changed in cinder:
assignee: nobody → Rajini Ram (rajini-ram)
tags: added: driver
summary: - EqualLogic driver is ignoring the ssh attempts eqlx_cli_max_retrie
+ EqualLogic driver is ignoring the ssh retries on timeout

Fix proposed to branch: master
Review: https://review.openstack.org/148715

Changed in cinder:
status: New → In Progress
Mike Perez (thingee) on 2015-01-21
tags: added: drivers eqlx
removed: driver
Rajini Karthik (rajini-karthik) wrote :

This has to be merged for Juno backport 1/31

Reviewed: https://review.openstack.org/148715
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=440beba26d0bc6c27ff837a6772c05a901ec23de
Submitter: Jenkins
Branch: master

commit 440beba26d0bc6c27ff837a6772c05a901ec23de
Author: rajinir <email address hidden>
Date: Tue Jan 20 13:52:32 2015 -0600

    Fix the eqlx driver to retry on ssh timeout

    When the ssh session is timing out, the driver
    should make attempts to retry based on the value
    in eqlx_cli_max_retries. Instead it was raising
    the exception and bailing out on a single attempt.

    Fixed the driver to raise a different exception
    so the ssh sessions can be retried.

    Added unit tests to ensure the max retries
    happen

    Also fixed the actual attempts made in the message

    Change-Id: I9bda46f9ef63eec436a381da3c96c09ce77c31ef
    Closes-Bug: #1412940

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx) on 2015-02-05
Changed in cinder:
milestone: none → kilo-2
status: Fix Committed → Fix Released

Change abandoned by Rajini Ram (<email address hidden>) on branch: stable/juno
Review: https://review.openstack.org/151303
Reason: Abandon this in favor of this
https://review.openstack.org/154123

Thierry Carrez (ttx) on 2015-04-30
Changed in cinder:
milestone: kilo-2 → 2015.1.0

Change abandoned by Mike Perez (<email address hidden>) on branch: stable/juno
Review: https://review.openstack.org/151303
Reason: Over a month with no update.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers