HP 3PAR modules do not follow coding guidelines

[Richard Hagarty]

Found multiple instances in test_hp3par and hp_3par_common which violate coding/style guidelines -

1) Use "," instead of "%" when adding variables to log messages. This allows logging to skip creating the formatted message when it won't be displayed due to the current log level.

2) Using "\" to continue lines should be avoided.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/149373

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/149373
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=13eb0cfba3c2971ef39baa010d43707aa5226fd0
Submitter: Jenkins
Branch: master

commit 13eb0cfba3c2971ef39baa010d43707aa5226fd0
Author: Rich Hagarty <email address hidden>
Date: Fri Jan 16 13:11:28 2015 -0800

    HP 3PAR modules do not follow coding guidelines

    Should use "," instead of "%" in logging messages, and
    the use of "\" to continue lines should be avoided.

    Change-Id: I23d53d66fda47981ed8f20b618b2ced8ef6e0682
    Closes-Bug: #1411370

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/149799
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=1bab7b69a81c33e09d730cdf35f9e2ad4b97046a
Submitter: Jenkins
Branch: master

commit 1bab7b69a81c33e09d730cdf35f9e2ad4b97046a
Author: Rich Hagarty <email address hidden>
Date: Fri Jan 23 17:44:53 2015 -0800

    HP 3PAR modules have bad log messages

    Some log messages are incorrectly formatted. Specifically, those
    messages that take multiple variables. In this case, each variable
    needs to be assigned a unique placeholder.

    This defect was recently introduced when all log messages where
    updated to use "," instead of "%" (see
    Change-Id: I23d53d66fda47981ed8f20b618b2ced8ef6e0682),
    which allowed translations to be ignored if not required by current
    log levels.

    Change-Id: Ic3439ba24c61579457dee206064bed2465ae4b6b
    Closes-Bug: #1411370