cinder unit tests currently failing with due to missing required option lock_path

[Jay Bryant]

There are 12 test cases in test_storwize_svc that are currently failing in local unit testing and in the check with the following failure:

2015-01-13 18:48:46.868 | FAIL: cinder.tests.test_storwize_svc.StorwizeSVCDriverTestCase.test_storwize_initiator_single_preferred_node_matching
2015-01-13 18:48:46.868 | tags: worker-0
2015-01-13 18:48:46.869 | ----------------------------------------------------------------------
2015-01-13 18:48:46.869 | Traceback (most recent call last):
2015-01-13 18:48:46.869 | File "cinder/tests/test_storwize_svc.py", line 2905, in test_storwize_initiator_single_preferred_node_matching
2015-01-13 18:48:46.869 | init_ret = self.driver.initialize_connection(volume, connector)
2015-01-13 18:48:46.869 | File "cinder/zonemanager/utils.py", line 76, in decorator
2015-01-13 18:48:46.869 | conn_info = initialize_connection(self, *args, **kwargs)
2015-01-13 18:48:46.869 | File "/home/jenkins/workspace/gate-cinder-python27/.tox/py27/local/lib/python2.7/site-packages/oslo_concurrency/lockutils.py", line 425, in inner
2015-01-13 18:48:46.869 | do_log=False, semaphores=semaphores, delay=delay):
2015-01-13 18:48:46.869 | File "/usr/lib/python2.7/contextlib.py", line 17, in __enter__
2015-01-13 18:48:46.869 | return self.gen.next()
2015-01-13 18:48:46.869 | File "/home/jenkins/workspace/gate-cinder-python27/.tox/py27/local/lib/python2.7/site-packages/oslo_concurrency/lockutils.py", line 380, in lock
2015-01-13 18:48:46.869 | ext_lock = external_lock(name, lock_file_prefix, lock_path)
2015-01-13 18:48:46.870 | File "/home/jenkins/workspace/gate-cinder-python27/.tox/py27/local/lib/python2.7/site-packages/oslo_concurrency/lockutils.py", line 317, in external_lock
2015-01-13 18:48:46.870 | lock_file_path = _get_lock_path(name, lock_file_prefix, lock_path)
2015-01-13 18:48:46.870 | File "/home/jenkins/workspace/gate-cinder-python27/.tox/py27/local/lib/python2.7/site-packages/oslo_concurrency/lockutils.py", line 311, in _get_lock_path
2015-01-13 18:48:46.870 | raise cfg.RequiredOptError('lock_path')
2015-01-13 18:48:46.870 | RequiredOptError: value required for option: lock_path
2015-01-13 18:48:46.870 | Traceback (most recent call last):
2015-01-13 18:48:46.870 | _StringException: Empty attachments:
2015-01-13 18:48:46.870 | stderr
2015-01-13 18:48:46.870 | stdout
2015-01-13 18:48:46.870 |
2015-01-13 18:48:46.870 | Traceback (most recent call last):
2015-01-13 18:48:46.870 | File "cinder/tests/test_storwize_svc.py", line 2905, in test_storwize_initiator_single_preferred_node_matching
2015-01-13 18:48:46.871 | init_ret = self.driver.initialize_connection(volume, connector)
2015-01-13 18:48:46.871 | File "cinder/zonemanager/utils.py", line 76, in decorator
2015-01-13 18:48:46.871 | conn_info = initialize_connection(self, *args, **kwargs)
2015-01-13 18:48:46.871 | File "/home/jenkins/workspace/gate-cinder-python27/.tox/py27/local/lib/python2.7/site-packages/oslo_concurrency/lockutils.py", line 425, in inner
2015-01-13 18:48:46.871 | do_log=False, semaphores=semaphores, delay=delay):
2015-01-13 18:48:46.871 | File "/usr/lib/python2.7/contextlib.py", line 17, in __enter__
2015-01-13 18:48:46.871 | return self.gen.next()
2015-01-13 18:48:46.871 | File "/home/jenkins/workspace/gate-cinder-python27/.tox/py27/local/lib/python2.7/site-packages/oslo_concurrency/lockutils.py", line 380, in lock
2015-01-13 18:48:46.871 | ext_lock = external_lock(name, lock_file_prefix, lock_path)
2015-01-13 18:48:46.940 | File "/home/jenkins/workspace/gate-cinder-python27/.tox/py27/local/lib/python2.7/site-packages/oslo_concurrency/lockutils.py", line 317, in external_lock
2015-01-13 18:48:46.940 | lock_file_path = _get_lock_path(name, lock_file_prefix, lock_path)
2015-01-13 18:48:46.940 | File "/home/jenkins/workspace/gate-cinder-python27/.tox/py27/local/lib/python2.7/site-packages/oslo_concurrency/lockutils.py", line 311, in _get_lock_path
2015-01-13 18:48:46.940 | raise cfg.RequiredOptError('lock_path')
2015-01-13 18:48:46.940 | RequiredOptError: value required for option: lock_path
2015-01-13 18:48:46.940 |
2015-01-13 18:48:46.940 | Traceback (most recent call last):
2015-01-13 18:48:46.940 | _StringException: Empty attachments:
2015-01-13 18:48:46.940 | stderr
2015-01-13 18:48:46.940 | stdout
2015-01-13 18:48:46.940 |
2015-01-13 18:48:46.941 | Traceback (most recent call last):
2015-01-13 18:48:46.941 | File "cinder/tests/test_storwize_svc.py", line 2905, in test_storwize_initiator_single_preferred_node_matching
2015-01-13 18:48:46.941 | init_ret = self.driver.initialize_connection(volume, connector)
2015-01-13 18:48:46.941 | File "cinder/zonemanager/utils.py", line 76, in decorator
2015-01-13 18:48:46.941 | conn_info = initialize_connection(self, *args, **kwargs)
2015-01-13 18:48:46.941 | File "/home/jenkins/workspace/gate-cinder-python27/.tox/py27/local/lib/python2.7/site-packages/oslo_concurrency/lockutils.py", line 425, in inner
2015-01-13 18:48:46.941 | do_log=False, semaphores=semaphores, delay=delay):
2015-01-13 18:48:46.941 | File "/usr/lib/python2.7/contextlib.py", line 17, in __enter__
2015-01-13 18:48:46.941 | return self.gen.next()
2015-01-13 18:48:46.941 | File "/home/jenkins/workspace/gate-cinder-python27/.tox/py27/local/lib/python2.7/site-packages/oslo_concurrency/lockutils.py", line 380, in lock
2015-01-13 18:48:46.941 | ext_lock = external_lock(name, lock_file_prefix, lock_path)
2015-01-13 18:48:46.942 | File "/home/jenkins/workspace/gate-cinder-python27/.tox/py27/local/lib/python2.7/site-packages/oslo_concurrency/lockutils.py", line 317, in external_lock
2015-01-13 18:48:46.942 | lock_file_path = _get_lock_path(name, lock_file_prefix, lock_path)
2015-01-13 18:48:46.942 | File "/home/jenkins/workspace/gate-cinder-python27/.tox/py27/local/lib/python2.7/site-packages/oslo_concurrency/lockutils.py", line 311, in _get_lock_path
2015-01-13 18:48:46.942 | raise cfg.RequiredOptError('lock_path')
2015-01-13 18:48:46.942 | RequiredOptError: value required for option: lock_path

[Jay Bryant (jsbryant)]

New oslo_concurrency was released at 9 am, I am guessing that is related.

[Jay Bryant (jsbryant)]

The problem appears to have been introduced by commit 9dd6d212f0d8fd74c29077a786fb6d770a2a0bba -- https://github.com/openstack/oslo.concurrency/commit/9dd6d212f0d8fd74c29077a786fb6d770a2a0bba

Have a patch that needs a little cleanup that will use set_defaults to avoid this problem.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/146997

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/146997
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=1b2ce8b2ef648b9c00dee53b84ca00b2a05ae3e2
Submitter: Jenkins
Branch: master

commit 1b2ce8b2ef648b9c00dee53b84ca00b2a05ae3e2
Author: Jay S. Bryant <email address hidden>
Date: Tue Jan 13 16:25:24 2015 -0600

    Use lockutils.set_defaults to set lock_path in test

    Commit 9dd6d212f0d8fd74c29077a786fb6d770a2a0bba for oslo.concurrency's
    lockutils appears to have broken our unit tests.

    Twelve of the the storwize_svc unit tests started failing with the
    complaint that the required configuration option 'lock_path' was not set.

    This change updates cinder/test.py to not only set up a temporary
    lock_path location that will be automatically cleaned up, but to also
    register that temporary lock_path location using lockutils.set_defaults()
    to correct the problem.

    Change-Id: I011888f676ebc170e7285048b7e5a638a5a8c9a9
    Closes-bug: 1410485