Enable Cinder hacking checks
Bug #1407162 reported by
Ivan Kolodyazhny
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Cinder |
Fix Released
|
Wishlist
|
Cindy Pallares |
Bug Description
Following PEP8/Flake8 check should be enabled to make core more clean and readable and consistent with OpenStack Hacking rules:
E265: block comment should start with '# ' - makes code more readable
H302: import only modules - OpenStack coding guidelines
H405: multi line docstring summary not separated with an empty line - OpenStack coding guidelines
Changed in cinder: | |
assignee: | nobody → Ivan Kolodyazhny (e0ne) |
description: | updated |
Changed in cinder: | |
importance: | Undecided → Medium |
status: | New → Confirmed |
Changed in cinder: | |
assignee: | Yuriy Nesenenko (ynesenenko) → Anton Arefiev (aarefiev) |
Changed in cinder: | |
milestone: | none → kilo-3 |
Changed in cinder: | |
assignee: | Anton Arefiev (aarefiev) → Yuriy Nesenenko (ynesenenko) |
Changed in cinder: | |
assignee: | Yuriy Nesenenko (ynesenenko) → Anton Arefiev (aarefiev) |
Changed in cinder: | |
assignee: | Anton Arefiev (aarefiev) → Yuriy Nesenenko (ynesenenko) |
Changed in cinder: | |
assignee: | Yuriy Nesenenko (ynesenenko) → Anton Arefiev (aarefiev) |
Changed in cinder: | |
assignee: | Anton Arefiev (aarefiev) → Yuriy Nesenenko (ynesenenko) |
Changed in cinder: | |
assignee: | Yuriy Nesenenko (ynesenenko) → Anton Arefiev (aarefiev) |
Changed in cinder: | |
assignee: | Anton Arefiev (aarefiev) → Yuriy Nesenenko (ynesenenko) |
Changed in cinder: | |
assignee: | Yuriy Nesenenko (ynesenenko) → Anton Arefiev (aarefiev) |
Changed in cinder: | |
assignee: | Anton Arefiev (aarefiev) → Yuriy Nesenenko (ynesenenko) |
Changed in cinder: | |
assignee: | Yuriy Nesenenko (ynesenenko) → Anton Arefiev (aarefiev) |
Changed in cinder: | |
assignee: | Anton Arefiev (aarefiev) → Yuriy Nesenenko (ynesenenko) |
Changed in cinder: | |
assignee: | Yuriy Nesenenko (ynesenenko) → Anton Arefiev (aarefiev) |
Changed in cinder: | |
milestone: | kilo-3 → liberty-1 |
Changed in cinder: | |
assignee: | Walt Boring (walter-boring) → nobody |
Changed in cinder: | |
assignee: | nobody → Cindy Pallares (cindy-pallaresq) |
Changed in cinder: | |
importance: | Low → Wishlist |
Changed in cinder: | |
milestone: | liberty-1 → liberty-2 |
Changed in cinder: | |
milestone: | liberty-2 → liberty-3 |
Changed in cinder: | |
status: | Fix Committed → Fix Released |
Changed in cinder: | |
milestone: | liberty-3 → 7.0.0 |
To post a comment you must log in.
Some of these have been discussed and rejected already (e.g. the git period one) with "Who cares? How does that make anything actually better?". Lots of hacking checks are possible, but unless they do actually make a noticable difference to the code, all they do is annoy developers who have to go fix them up.