NetApp driver proxy doesn't work with abstract base classes

Bug #1405060 reported by Clinton Knight
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Low
Clinton Knight

Bug Description

NetApp's proxy driver implementation required a hack ("ProxyVD") in the Abstract Base Classes project in Cinder because the proxy class does not extend VolumeDriver. A proper factory implementation can remove the need for the hack, and it also can improve logging, because the actual driver object would be provided to the volume manager instead of the driver proxy.

Changed in cinder:
assignee: nobody → Clinton Knight (clintonk)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/143661

Changed in cinder:
status: New → In Progress
Jay Bryant (jsbryant)
Changed in cinder:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/143661
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=f10703d8b0dab00357c92840d958832f779e8450
Submitter: Jenkins
Branch: master

commit f10703d8b0dab00357c92840d958832f779e8450
Author: Clinton Knight <email address hidden>
Date: Fri Dec 12 15:30:26 2014 -0500

    Replace the NetApp driver proxy layer with a proper factory.

    The proxy implementation required a hack in the Abstract Base
    Classes project in Cinder core. This factory implementation
    removes the need for the hack. It also improves logging, as
    the actual driver object is provided to the volume manager
    instead of the driver proxy.

    Change-Id: I28f4798b9e799547d1696d2f135d3302b3c553fe
    Closes-Bug: 1405060

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in cinder:
milestone: none → kilo-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: kilo-2 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.