storpool driver missing dependencies, tox genconfig broken

Bug #1403532 reported by Eric Harney
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
High
John Griffith

Bug Description

cinder.volume.drivers.storpool does:

import storpool

But storpool is not in requirements.txt. This causes "tox -e genconfig" to fail. This is broken, modules like this must either be in requirements.txt or loaded in a way to gracefully handle them missing.

Jay Bryant (jsbryant)
Changed in cinder:
importance: Undecided → High
Changed in cinder:
status: New → Confirmed
Revision history for this message
John Griffith (john-griffith) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/143570

Changed in cinder:
assignee: nobody → John Griffith (john-griffith)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/143570
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=84431839d972a9a2339ee220e3183130cd47c11c
Submitter: Jenkins
Branch: master

commit 84431839d972a9a2339ee220e3183130cd47c11c
Author: John Griffith <email address hidden>
Date: Mon Dec 22 17:05:01 2014 -0700

    Fix broken StorPool driver

    The newly added StorPool driver has a number of issues;
    It imports it's own 3'rd party libs which are not in the
    requirements file, it declares conf options but never registers
    them, and as a result of these two things it break the ability
    to generate a configuration file.

    This patch adds a try_import around the import storpool calls
    like we do in other drivers, and it registers the config options
    properly.

    We also move the api setting out of init and into the check_setup
    so the service doesn't crash if somebody tries to load the driver
    without the required storpool modules.

    Closes-Bug: 1405023
    Closes-Bug: 1405022
    Closes-Bug: 1405016
    Closes-Bug: 1403532

    Change-Id: I61340ab7c5abcdc21dbb12cf0693da036e69e90c

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in cinder:
milestone: none → kilo-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: kilo-2 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.