Incorrectly formatted Error message in brick/iscsi/iscsi.py

[John Griffith]

Currently in cinder.brick.iscsi.iscs:LioADM.create_iscsi_target
The Log message for the exception is: LOG.error("%s" % e), this rightfully results in:
*** UnicodeError: UnicodeError(u'Message objects do not support str() because they may contain non-ascii characters. Please use unicode() or translate() instead.',)

Note there are other places in the file that have this problem, not just the create_target call and not just the LIO class.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/142913

[OpenStack Infra (hudson-openstack)]

Change abandoned by John Griffith (<email address hidden>) on branch: master
Review: https://review.openstack.org/142913
Reason: This is completely hosed anyway:
http://logs.openstack.org/13/142913/1/check/check-tempest-dsvm-full/bdbed05/logs/screen-c-vol.txt.gz#_2014-12-18_22_41_05_757

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/158001

[Gorka Eguileor (gorka)]

I think this bug should not have been closed, as committed fix is for TGT and not LIO target which is the one that this bug is mentioning.

[Gorka Eguileor (gorka)]

This bug doesn't affect LIO on master anymore, even if this isn't the patch that fixed it.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/180645

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/180645
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=d89f493c2dc535b9110d222f3806d1a7fa208618
Submitter: Jenkins
Branch: stable/juno

commit d89f493c2dc535b9110d222f3806d1a7fa208618
Author: Gorka Eguileor <email address hidden>
Date: Wed May 6 19:25:35 2015 +0200

    Fix exceptions logging in iSCSI targets

    On multiple iSCSI target helpers you could get an unexpected exception
    regarding non-ascii chars if the volume name contained unicode
    characters.

    It could also happen if debugging was enabled and stdout contained unicode
    characters.

    To fix this we changed to delayed string interpolation and removed any
    force type translation of variables on iSCSI targets.

    Change-Id: I76bb87ff5f0014f27fda4c4d2bfff7a5e2bf1535
    Closes-Bug: #1402078