volume/snapshot allows name with only white spaces

Bug #1370297 reported by Gloria Gu
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Invalid
Undecided
Unassigned
OpenStack Dashboard (Horizon)
Won't Fix
Undecided
Unassigned

Bug Description

When create or edit volume or snapshot, it allows name field with only white spaces.

How to reproduce:

Just go to project -> volume to create a volume with only white spaces a name, the volume shows up in the volume table with an empty name.

same for snapshot

Expect:

form should not allow empty name when create/edit volume or snapshot

This is split from https://bugs.launchpad.net/horizon/+bug/1357586 since volume and snapshot name is different from volume type name.

Revision history for this message
Gloria Gu (gloria-gu) wrote :
Revision history for this message
Gloria Gu (gloria-gu) wrote :

need wait for cinder side to more sure and fixed.

Liyingjun (liyingjun)
Changed in cinder:
assignee: nobody → Liyingjun (liyingjun)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/122092

Changed in cinder:
status: New → In Progress
Revision history for this message
Duncan Thomas (duncan-thomas) wrote :

I'm not sure this is a bug - if a tenant wants to use white space as their volume name, we should let them - it is a free text field.

Revision history for this message
Gloria Gu (gloria-gu) wrote :

if --display-name is specified, better prevent enter just empty spaces, otherwise empty volume names and snapshot names look so silly.

Revision history for this message
Gloria Gu (gloria-gu) wrote :

not finished yet : ), I mean in UI they look so silly especially when volumes and snapshots in a selection list.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on cinder (master)

Change abandoned by Li Yingjun (<email address hidden>) on branch: master
Review: https://review.openstack.org/122092

Revision history for this message
Gloria Gu (gloria-gu) wrote :

Well , from UI world, if empty spaces cause issues, it would be better prevent it which is a common practice. However openstack folks don't agree. It is a trivial issue so it is not worth to push it.

Revision history for this message
Gloria Gu (gloria-gu) wrote :

It is more of Won't Fix, but I change it to be invalid.

Changed in horizon:
status: New → Invalid
Revision history for this message
Gloria Gu (gloria-gu) wrote :

think , it is more of won't fix. The bug is still valid.

Changed in horizon:
status: Invalid → New
Revision history for this message
Gary W. Smith (gary-w-smith) wrote :

Changing status per comment #10

Changed in horizon:
status: New → Won't Fix
Mike Perez (thingee)
Changed in cinder:
assignee: Liyingjun (liyingjun) → nobody
status: In Progress → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.