QOS Spec creation should validate name and key-value pairs

Bug #1370194 reported by Richard Hagarty
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Invalid
Medium
Unassigned

Bug Description

These commands should not be valid -

cinder qos-create " " consumer=back-end " "=" "

cinder qos-key <id> set " "=" "

Validation checks should ensure that non-blank values are entered for both the QOS spec name and for spec key-value pairs

Changed in cinder:
status: New → Triaged
importance: Undecided → Medium
Liyingjun (liyingjun)
Changed in cinder:
assignee: nobody → Liyingjun (liyingjun)
status: Triaged → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/122040

Changed in cinder:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on cinder (master)

Change abandoned by Li Yingjun (<email address hidden>) on branch: master
Review: https://review.openstack.org/122040

Revision history for this message
Sean McGinnis (sean-mcginnis) wrote :

Automatically unassigning due to inactivity.

Changed in cinder:
assignee: Liyingjun (liyingjun) → nobody
status: In Progress → Triaged
Revision history for this message
Vincent Hou (houshengbo) wrote :

Since it is not possible to tell what key is valid given the infinite possibilities are out there for so many back-ends, it is better that we do not validate key or value for now unless there is further proof of this breaking Cinder or causing security issues.

Changed in cinder:
status: Triaged → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.