3PAR attach/detach_volume missing login and logout

[Walt Boring]

The 3PAR iSCSI and FC driver's attach_volume are missing the client login and logout. This causes leaking sessions on the 3PAR array.

There is a limit on the # of sessions a 3PAR backend can have active and certain situations (such as a stress test) would cause that limit to be reached because of this bug.

While the sessions will eventually close on their own after 15 minutes it is still good to have this bug fixed. Left unfixed it will cause problems during high load situations.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/120221

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/120221
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=519aa064f56447b4a0b1bdbde06f26afe139223d
Submitter: Jenkins
Branch: master

commit 519aa064f56447b4a0b1bdbde06f26afe139223d
Author: Anthony Lee <email address hidden>
Date: Tue Sep 9 06:53:25 2014 -0700

    Fixing leaking sessions in 3PAR on attach/detach

    Fixed an issue where sessions were not being closed properly
    during an attach or detach of a volume.

    Closes-Bug: 1367429
    Change-Id: Ic7a4ceca855111a8c8a9512fc2d99fcf6df6d79e

[Michael Denny (michael-denny)]

HP3PARclient side errors are as follows, 403 invalid session key from WSAPI and leaves the session dangling.

REQ: curl -i https://10.10.20.241:8080/api/v1/volumes/osv-poaJoIFQT-.WbT5abgbIcg/objectKeyValues/HPQ-CS-instance_uuid DELETE -H "Accept: application/json" -H "User-Agent: python-3parclient"
[00m [00;33mfrom (pid=3843) _http_log_req /usr/local/lib/python2.7/dist-packages/hp3parclient/http.py:159[00m
RESP:{'connection': 'close',
'content-type': 'application/json',
'date': 'Thu, 04 Sep 2014 17:24:03 GMT',
'server': 'hp3par-wsapi',
'status': '403'}

2014-09-04 10:24:11.173 [00;32mDEBUG hp3parclient.http [[01;36mreq-f35c04d9-85c1-4043-bd32-0017f4e57005 [00;36md58b2f359802452884da20ddf2d7ecf9 b67d33ea3945422c96f16299f87ca5f0[00;32m] [01;35m[00;32mRESP:{'connection': 'close',
'content-type': 'application/json',
'date': 'Thu, 04 Sep 2014 17:24:03 GMT',
'server': 'hp3par-wsapi',
'status': '403'}
[00m [00;33mfrom (pid=3843) _http_log_resp /usr/local/lib/python2.7/dist-packages/hp3parclient/http.py:166[00m
RESP BODY:{"code":6,"desc":"invalid session key"}

A good request example
2014-09-04 10:24:11.649 [00;32mDEBUG hp3parclient.http [[01;36mreq-f35c04d9-85c1-4043-bd32-0017f4e57005 [00;36md58b2f359802452884da20ddf2d7ecf9 b67d33ea3945422c96f16299f87ca5f0[00;32m] [01;35m[00;32m
REQ: curl -i https://10.10.20.241:8080/api/v1/volumes/osv-poaJoIFQT-.WbT5abgbIcg/objectKeyValues/HPQ-CS-instance_uuid DELETE -H "X-Hp3Par-Wsapi-Sessionkey: 1bc-046640f4d011d1cffd1853340d9f2e33-34a00856" -H "Accept: application/json" -H "User-Agent: python-3parclient"
[00m [00;33mfrom (pid=3843) _http_log_req /usr/local/lib/python2.7/dist-packages/hp3parclient/http.py:159[00m
RESP:{'cache-control': 'no-cache',
'connection': 'close',
'date': 'Thu, 04 Sep 2014 17:24:04 GMT',
'pragma': 'no-cache',
'server': 'hp3par-wsapi',
'status': '200'}

2014-09-04 10:24:11.680 [00;32mDEBUG hp3parclient.http [[01;36mreq-f35c04d9-85c1-4043-bd32-0017f4e57005 [00;36md58b2f359802452884da20ddf2d7ecf9 b67d33ea3945422c96f16299f87ca5f0[00;32m] [01;35m[00;32mRESP:{'cache-control': 'no-cache',
'connection': 'close',
'date': 'Thu, 04 Sep 2014 17:24:04 GMT',
'pragma': 'no-cache',
'server': 'hp3par-wsapi',
'status': '200'}
[00m [00;33mfrom (pid=3843) _http_log_resp /usr/local/lib/python2.7/dist-packages/hp3parclient/http.py:166[00m
RESP BODY: