gpfs driver not setting pool information properly

[Sasikanth Eda]

In the current code, the configuration option 'gpfs_storage_pool' is assigned with default value of 'None'

And in the do_setup(), it line self._storage_pool = pool or system, it get assigned with "None" if the user has not specified any value.

Following is seen in the c-vol log.

2014-09-04 17:43:44.039 TRACE cinder.volume.manager Traceback (most recent call last):
2014-09-04 17:43:44.039 TRACE cinder.volume.manager File "/opt/stack/cinder/cinder/volume/manager.py", line 250, in init_host
2014-09-04 17:43:44.039 TRACE cinder.volume.manager self.driver.do_setup(ctxt)
2014-09-04 17:43:44.039 TRACE cinder.volume.manager File "/usr/local/lib/python2.7/dist-packages/osprofiler/profiler.py", line 105, in wrapper
2014-09-04 17:43:44.039 TRACE cinder.volume.manager return f(*args, **kwargs)
2014-09-04 17:43:44.039 TRACE cinder.volume.manager File "/opt/stack/cinder/cinder/volume/drivers/ibm/gpfs.py", line 341, in do_setup
2014-09-04 17:43:44.039 TRACE cinder.volume.manager raise exception.VolumeBackendAPIException(data=msg)
2014-09-04 17:43:44.039 TRACE cinder.volume.manager VolumeBackendAPIException: Bad or unexpected response from the storage volume backend API: Invalid storage pool None specificed.

"gpfs_storage_pool" option needs to assigned by default with "system" instead of "None"

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/119053

[Nilesh Bhosale (nilesh-bhosale)]

Sure thanks Jay, I had not noticed the bug Sasi raised for this.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/119053
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=ce7c8dfba800874fec7411393e6799d81064f939
Submitter: Jenkins
Branch: master

commit ce7c8dfba800874fec7411393e6799d81064f939
Author: Manojkiran <manojkiran@manojkiran.(none)>
Date: Thu Sep 4 18:03:57 2014 +0530

    Set default pool value to system in gpfs driver

    The configuration option gpfs_storage_pool is assigned with
    default value of None. And it gets initialized with None
    instead of system, where as the intention is to set the default
    value as system.

    This change sets default value of gpfs_storage_pool to system
    instead of None.

    DocImpact

    Needs an update in gpfs driver documentation, as this patch
    proposes a change in default value of configuration option
    (gpfs_storage_pool)

    Change-Id: Ib4c2a2e4593a940ae563d329fd59d2d5fe3d4520
    Closes-Bug: #1365474