c-vol.log reports "Error checking replication status" for non-replication volumes every 1 minutes

[yixuan zhang]

Test Steps:
1. Run Cinder CI with ibm storwize storage, it was found much more ERRORs than before:

10:11:45 *** Not Whitelisted *** 2014-09-04 14:49:54.821 29428 ERROR cinder.volume.manager [-] Error checking replication status for volume 438e620d-8b04-49c0-9968-820c2bf8590f
10:11:45 *** Not Whitelisted *** 2014-09-04 14:50:54.769 29428 ERROR cinder.volume.manager [-] Error checking replication status for volume 3c9e9a38-e606-47f7-bbea-c3e84205bd79
10:11:45 *** Not Whitelisted *** 2014-09-04 14:52:54.799 29428 ERROR cinder.volume.manager [-] Error checking replication status for volume fedb9af6-d7dc-4f0d-ad7b-eb28127ac507

2. Manually Create volumes without replication on IBM storwize v7000u, the volume creation successfully.
3. Check c-vol.log, it was found the below logs every 1 minutes:

2014-09-04 17:07:11.515 ERROR cinder.volume.manager [-] Error checking replication status for volume d2ffa93d-4140-4f1e-bcb7-c70af51781a3
2014-09-04 17:07:11.515 TRACE cinder.volume.manager Traceback (most recent call last):
2014-09-04 17:07:11.515 TRACE cinder.volume.manager File "/opt/stack/cinder/cinder/volume/manager.py", line 1597, in _update_replication_relationship_status
2014-09-04 17:07:11.515 TRACE cinder.volume.manager ctxt, vol)
2014-09-04 17:07:11.515 TRACE cinder.volume.manager File "/usr/local/lib/python2.7/dist-packages/osprofiler/profiler.py", line 105, in wrapper
2014-09-04 17:07:11.515 TRACE cinder.volume.manager return f(*args, **kwargs)
2014-09-04 17:07:11.515 TRACE cinder.volume.manager File "/opt/stack/cinder/cinder/volume/drivers/ibm/storwize_svc/__init__.py", line 756, in get_replication_status
2014-09-04 17:07:11.515 TRACE cinder.volume.manager return self.replication.get_replication_status(volume)
2014-09-04 17:07:11.515 TRACE cinder.volume.manager AttributeError: 'NoneType' object has no attribute 'get_replication_status'
2014-09-04 17:07:11.515 TRACE cinder.volume.manager
2014-09-04 17:07:11.516 ERROR cinder.volume.manager [-] Error checking replication status for volume d9791267-bb7a-448c-938e-c98dff38bcf5
2014-09-04 17:07:11.516 TRACE cinder.volume.manager Traceback (most recent call last):
2014-09-04 17:07:11.516 TRACE cinder.volume.manager File "/opt/stack/cinder/cinder/volume/manager.py", line 1597, in _update_replication_relationship_status
2014-09-04 17:07:11.516 TRACE cinder.volume.manager ctxt, vol)
2014-09-04 17:07:11.516 TRACE cinder.volume.manager File "/usr/local/lib/python2.7/dist-packages/osprofiler/profiler.py", line 105, in wrapper
2014-09-04 17:07:11.516 TRACE cinder.volume.manager return f(*args, **kwargs)
2014-09-04 17:07:11.516 TRACE cinder.volume.manager File "/opt/stack/cinder/cinder/volume/drivers/ibm/storwize_svc/__init__.py", line 756, in get_replication_status
2014-09-04 17:07:11.516 TRACE cinder.volume.manager return self.replication.get_replication_status(volume)
2014-09-04 17:07:11.516 TRACE cinder.volume.manager AttributeError: 'NoneType' object has no attribute 'get_replication_status'
2014-09-04 17:07:11.516 TRACE cinder.volume.manager
2014-09-04 17:07:11.516 ERROR cinder.volume.manager [-] Error checking replication status for volume fedd3b21-d60e-497e-b309-b125d81b1bcd
2014-09-04 17:07:11.516 TRACE cinder.volume.manager Traceback (most recent call last):
2014-09-04 17:07:11.516 TRACE cinder.volume.manager File "/opt/stack/cinder/cinder/volume/manager.py", line 1597, in _update_replication_relationship_status
2014-09-04 17:07:11.516 TRACE cinder.volume.manager ctxt, vol)
2014-09-04 17:07:11.516 TRACE cinder.volume.manager File "/usr/local/lib/python2.7/dist-packages/osprofiler/profiler.py", line 105, in wrapper
2014-09-04 17:07:11.516 TRACE cinder.volume.manager return f(*args, **kwargs)
2014-09-04 17:07:11.516 TRACE cinder.volume.manager File "/opt/stack/cinder/cinder/volume/drivers/ibm/storwize_svc/__init__.py", line 756, in get_replication_status
2014-09-04 17:07:11.516 TRACE cinder.volume.manager return self.replication.get_replication_status(volume)
2014-09-04 17:07:11.516 TRACE cinder.volume.manager AttributeError: 'NoneType' object has no attribute 'get_replication_status'
2014-09-04 17:07:11.516 TRACE cinder.volume.manager

3. Expected result:
There is no replication status update Error for those volumes without replication.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/121774

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/121774
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=3783c50dce3917257060dd977f69785238f58078
Submitter: Jenkins
Branch: master

commit 3783c50dce3917257060dd977f69785238f58078
Author: TaoBai <email address hidden>
Date: Tue Sep 16 11:14:16 2014 +0300

    Check replication status failed for non-replication

    Need to check self.replication whether is None before the
    function get_replication_status be called.

    Closes-bug: #1365392

    Change-Id: I6f6939a98091e40537f2355bb716b4b3205845e2

[yixuan zhang (yixuan-z)]

Verify passed on storwize SVC, check the latest CI log, there is no same issue found.

[TaoBai (baitao2020)]

Thanks for you verified it