Extended_snasphot_attributes extension doesn't work with all_tenants=1

Bug #1358960 reported by Vish Ishaya
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Medium
Vish Ishaya
Icehouse
Fix Released
Medium
John Griffith

Bug Description

The extended snapshot attributes extension adds project_id and progress to the output but this does not work when all_tenants=1 is passed into snapshots/details. This is because the extension makes a second request to the api for the snapshot data, but it doens't pass in the expanded filter.

This could be fixed to pass in the filter, but a better fix (which would also solve performance problems) would be to have it cache the snapshots locally like it does for volumes and not re-request them.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/115436

Changed in cinder:
assignee: nobody → Vish Ishaya (vishvananda)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (stable/icehouse)

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/115726

Changed in cinder:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/115436
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=4f0d1d36136bcb33f578b2999812f36cadd71cec
Submitter: Jenkins
Branch: master

commit 4f0d1d36136bcb33f578b2999812f36cadd71cec
Author: Vishvananda Ishaya <email address hidden>
Date: Tue Aug 19 16:59:02 2014 -0700

    Cache snapshots in request for extension

    The extended snapshots extension makes a separate db request for
    snapshots which is horribly inefficent. In addition it causes an
    issue when using all_tenants=1, because the second request doesn't
    pass in the filter. Fix this by caching the snapshot in the request
    object like we do for volumes and retrieve the cached object in the
    extension.

    Change-Id: Ia943438c8d48accb7f62c43f07642c3da2fe34ab
    Resolves-bug: #1358960

Changed in cinder:
status: In Progress → Fix Committed
tags: added: icehouse-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (stable/icehouse)

Reviewed: https://review.openstack.org/115726
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=36406c9bb0bac99b5daf1b8194df73685cbe49ea
Submitter: Jenkins
Branch: stable/icehouse

commit 36406c9bb0bac99b5daf1b8194df73685cbe49ea
Author: Vishvananda Ishaya <email address hidden>
Date: Tue Aug 19 16:59:02 2014 -0700

    Cache snapshots in request for extension

    The extended snapshots extension makes a separate db request for
    snapshots which is horribly inefficent. In addition it causes an
    issue when using all_tenants=1, because the second request doesn't
    pass in the filter. Fix this by caching the snapshot in the request
    object like we do for volumes and retrieve the cached object in the
    extension.

    Change-Id: Ia943438c8d48accb7f62c43f07642c3da2fe34ab
    Resolves-bug: #1358960
    (cherry picked from commit 4f0d1d36136bcb33f578b2999812f36cadd71cec)

    Conflicts:
     cinder/api/contrib/extended_snapshot_attributes.py

    Change-Id: Ia943438c8d48accb7f62c43f07642c3da2fe34ab

tags: added: in-stable-icehouse
Thierry Carrez (ttx)
Changed in cinder:
milestone: none → juno-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: juno-3 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.