Cannot run tests on OS X due to platform specific features

Bug #1357010 reported by Mathieu Gagné
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
Rick Chen

Bug Description

The commit c1afe8001c90a17463a62f0c5c454767a7d88d86 added tests to improve test coverage: https://review.openstack.org/43448

Those tests are platform dependent as they require loop device support which is not available on Mac OS X.

We should skip those tests on OS X.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/114309

Changed in cinder:
assignee: nobody → Mathieu Gagné (mgagne)
status: New → In Progress
Revision history for this message
Huang Zhiteng (zhiteng-huang) wrote :

I have also seen these on OS X. It seems 'ENAVAIL' errno code doesn't exist for OS X. We should do skip these tests as well.

======================================================================
FAIL: cinder.tests.test_prophetstor_dpl.TestProphetStorDPLDriver.test_delete_snapshot
----------------------------------------------------------------------
Traceback (most recent call last):
_StringException: Empty attachments:
  stderr
  stdout

Traceback (most recent call last):
  File "/opt/stack/cinder/cinder/tests/test_prophetstor_dpl.py", line 488, in test_delete_snapshot
    self.dpldriver.delete_snapshot(DATA_IN_SNAPSHOT)
  File "/opt/stack/cinder/cinder/volume/drivers/prophetstor/dplcommon.py", line 956, in delete_snapshot
    elif ret == errno.ENAVAIL:
AttributeError: 'module' object has no attribute 'ENAVAIL'

======================================================================
FAIL: cinder.tests.test_prophetstor_dpl.TestProphetStorDPLDriver.test_delete_volume
----------------------------------------------------------------------
Traceback (most recent call last):
_StringException: Empty attachments:
  stderr
  stdout

Traceback (most recent call last):
  File "/opt/stack/cinder/cinder/tests/test_prophetstor_dpl.py", line 438, in test_delete_volume
    self.dpldriver.delete_volume(DATA_IN_VOLUME)
  File "/opt/stack/cinder/cinder/volume/drivers/prophetstor/dplcommon.py", line 852, in delete_volume
    elif ret == errno.ENAVAIL:
AttributeError: 'module' object has no attribute 'ENAVAIL'

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/115333

Changed in cinder:
assignee: Mathieu Gagné (mgagne) → Rick Chen (rick-chen)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on cinder (master)

Change abandoned by Mathieu Gagné (<email address hidden>) on branch: master
Review: https://review.openstack.org/114309
Reason: Abandon in favour of:
- https://review.openstack.org/#/c/115333/
- https://review.openstack.org/#/c/114709/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/115333
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=f5217aa63c8e39e27d8fc782caad0c24a7265805
Submitter: Jenkins
Branch: master

commit f5217aa63c8e39e27d8fc782caad0c24a7265805
Author: Rick Chen <email address hidden>
Date: Wed Aug 20 00:12:23 2014 +0800

    Modify error code compatible with Mac OS.

    Mac OS builtin python errno object has no
    attribute 'ENAVAIL'.
    Changed
      errno.ENAVAIL --> errno.ENODATA
    Another when backend storage service not ready, the
    error code "ENAVAIL" change to "ENOPROTOOPT".

    Change-Id: I0c41dfe44a4dea02329ff21df881f4c133fe6099
    Closes-Bug: 1357010

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in cinder:
milestone: none → juno-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: juno-3 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.