VMware: Volume creation fails when config 'vmware_volume_folder' contains special characters

[Vipin Balachandran]

Set vmware_volume_folder=/cinder-volumes in cinder.conf

> cinder create 1
fails with following error:

Unable to find suitable datastore for volume of size: 1 GB under host: (obj){
   value = "host-361"
   _type = "HostSystem"
 }. More details: Server raised fault: 'The name '/cinder-volumes' already exists

[Vipin Balachandran (vbala)]

vCenter server escapes special characters in the folder name using URL encoding and returns back the encoded string while querying. This causes the check for folder existence to fail.

The workaround is to use folder name without '/', '\' or '% ' for vmware_volume_folder option value.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/114184

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/114184
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=f668b347ca181229fab4b89fda25f1aadfbfdef1
Submitter: Jenkins
Branch: master

commit f668b347ca181229fab4b89fda25f1aadfbfdef1
Author: Vipin Balachandran <email address hidden>
Date: Thu Aug 14 15:09:40 2014 +0530

    VMware:Unquote folder name for folder exists check

    vCenter server escapes special characters in the folder name using URL
    encoding and returns back the encoded string while querying. This causes
    the check for folder existence to return false. Therefore, folder
    creation is reattempted which eventually fails. This patch fixes the
    problem by decoding the folder name returned by vCenter before
    comparison.

    Change-Id: I40aa6f42ea0d85fbfcb40970c55b20e13ea46522
    Closes-Bug: #1356794