pylint/pep8: bad-whitespace issue

Bug #1356601 reported by Danny Al-Gaaf
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Invalid
Undecided
Unassigned

Bug Description

pylint found some pep8 bad-whitespace issues:

************* Module cinder.volume.drivers.netapp.nfs
C:645, 0: No space allowed before bracket
class NetAppDirectNfsDriver (NetAppNFSDriver):
                            ^ (bad-whitespace)
C:723, 0: No space allowed before bracket
class NetAppDirectCmodeNfsDriver (NetAppDirectNfsDriver):
                                 ^ (bad-whitespace)
C:1284, 0: No space allowed before bracket
class NetAppDirect7modeNfsDriver (NetAppDirectNfsDriver):
                                 ^ (bad-whitespace)

Changed in cinder:
assignee: nobody → Danny Al-Gaaf (danny-al-gaaf)
status: New → In Progress
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/114042

Revision history for this message
Duncan Thomas (duncan-thomas) wrote :

The correct fix for this is to fix our PEP8 run in cinder to detect this, just fixing it up by hand does nothing to avoid it catching us out again in future

Revision history for this message
Danny Al-Gaaf (danny-al-gaaf) wrote :

It seems that pylint complains but pep8 is fuzzy about this case. From the pep8 code for the E211 code (commit #5c5fde71ace3176d1a9bddaa5f11da4cc577d607):

# Syntax "class A (B):" is allowed, but avoid it

and:

# This is not prohibited by PEP8, but avoid it.
class Foo (Bar, Baz):

If a check is needed it needs to be implemented outside of pep8.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on cinder (master)

Change abandoned by Walter A. Boring IV (hemna) (<email address hidden>) on branch: master
Review: https://review.openstack.org/114042
Reason: abandoned by request of "akerr" in irc.

Revision history for this message
Sean McGinnis (sean-mcginnis) wrote :

Automatically unassigning due to inactivity.

Changed in cinder:
assignee: Danny Al-Gaaf (danny-al-gaaf) → nobody
status: In Progress → Triaged
Revision history for this message
Sean McGinnis (sean-mcginnis) wrote :

I don't believe this is still an issue. Please reopen (or just propose patch to fix) if it is.

Changed in cinder:
status: Triaged → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.