Cinder

Windows volume driver: wrong exception cought

Bug #1356398 reported by Lucian Petrut
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
Lucian Petrut
Cinder 2015.1.0 "kilo"

Bug Description

In the copy_vhd_disk method, it is assumed that if the copy operation fails, a wmi.x_wmi exception will be raised. This is wrong. In fact, none of the methods use there can raise such an exception in those circumstances.

At the moment, this method will not raise an exception even if the copy operation fails.

A check should be performed to see if the source image actually exists, and also check the return value of the according CIM_DataFile object Copy method in order to see if the operation failed or not.

Lucian Petrut (petrutlucian94)
tags: added: drivers icehouse-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/114171

Changed in cinder:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on cinder (master)

Change abandoned by Mike Perez (<email address hidden>) on branch: master
Review: https://review.openstack.org/114171

Mike Perez (thingee)
Changed in cinder:
status: In Progress → New
OpenStack Infra (hudson-openstack)
Changed in cinder:
status: New → In Progress
Mike Perez (thingee)
Changed in cinder:
status: In Progress → Triaged
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Mike Perez (<email address hidden>) on branch: master
Review: https://review.openstack.org/114171
Reason: no activity

OpenStack Infra (hudson-openstack)
Changed in cinder:
assignee: nobody → Petrut Lucian (petrutlucian94)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/114171
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=b5567ed10a2e49adca849456049393120e375965
Submitter: Jenkins
Branch: master

commit b5567ed10a2e49adca849456049393120e375965
Author: Nashwan Azhari <email address hidden>
Date: Wed Aug 13 17:46:45 2014 +0300

    Windows iSCSI driver: Fixes copy disk method exception handling

    In the copy_vhd_disk method, it is assumed that if the copy operation
    fails, a wmi.x_wmi exception will be raised. This is wrong. In fact,
    none of the methods called there can raise such an exception in those
    circumstances.

    At the moment, this method will not raise an exception even if the
    copy operation fails.

    This patch adds a check to see if the source image actually exists.
    The according CIM_DataFile Copy method's return value is checked as
    well in order to see if the operation failed or not.

    Change-Id: I778ecd61adb007995b629b36044caac78cd16889
    Closes-Bug: #1356398

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in cinder:
milestone: none → kilo-3
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (stable/juno)

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/170500

Thierry Carrez (ttx)
Changed in cinder:
milestone: kilo-3 → 2015.1.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on cinder (stable/juno)

Change abandoned by Petrut Lucian (<email address hidden>) on branch: stable/juno
Review: https://review.openstack.org/170500
Reason: Not a security related fix.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.