remove_multipath_device is used incorrectly in ISCSIConnector.disconnect_volume

[Jeegn Chen]

Currently in cinder/brick/initiator/connector.py, ISCSIConnector.disconnect_volume will try to remove multipatch device like this:

 multipath_device = self._get_multipath_device_name(host_device)
 if multipath_device:
    device_realpath = os.path.realpath(host_device)
    self._linuxscsi.remove_multipath_device(device_realpath)

But actually LinuxSCSI.remove_multipath_device is expecting a device UUID
instead of device_realpath, therefore remove_multipath_device will do nothing due to incorrect input.

The code should be changed to
 multipath_device = self._get_multipath_device_name(host_device)
 if multipath_device:
    self._linuxscsi.remove_multipath_device(
        multipath_device.split('/')[3])

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/112550

[OpenStack Infra (hudson-openstack)]

Change abandoned by Jeegn Chen (<email address hidden>) on branch: master
Review: https://review.openstack.org/112550
Reason: Not able to reproduce the issue and original implementation works.

[Jeegn Chen (jeegn-chen)]

Not able to reproduce the issue and original implementation works.
Dismiss the bug.