snapshot has wrong status in notification-info when it created done

Bug #1349805 reported by wuyuting
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
John Griffith

Bug Description

, Snapshot's status have update to 'available' in database when snapshot created successfully, but in 'notification-info' it still being 'creating'.

2014-07-28 10:42:25.711 3580 INFO cinder.volume.manager [req-3b3aadbc-eb00-4695-a24a-8ad8a8fa5194 ce5e930bf5a44167b149a2d5fd2302e6 7dfd3b6a98664f7cb78808f57b7984da - - -] snapshot f2264c3b-bb46-41fc-b59f-978a222d3ded: created successfully
2014-07-28 10:42:25.712 3580 INFO oslo.messaging._drivers.impl_zmq [req-3b3aadbc-eb00-4695-a24a-8ad8a8fa5194 ce5e930bf5a44167b149a2d5fd2302e6 7dfd3b6a98664f7cb78808f57b7984da - - -] 'notifications-info' {'event_type': 'snapshot.create.end',
 'message_id': '69eece40-3d3f-4d65-a239-4ba88d0a8ff5',
 'payload': {'availability_zone': u'nova',
             'created_at': '2014-07-28 02:42:25',
             'deleted': '',
             'display_name': None,
             'snapshot_id': u'f2264c3b-bb46-41fc-b59f-978a222d3ded',
             'status': u'creating',
             'tenant_id': u'7dfd3b6a98664f7cb78808f57b7984da',
             'user_id': u'ce5e930bf5a44167b149a2d5fd2302e6',
             'volume_id': u'd555f2ec-bc78-4f9b-a732-77c67b1fda3a',
             'volume_size': 1},
 'priority': 'INFO',
 'publisher_id': 'snapshot.controller1',
 'request_id': u'req-3b3aadbc-eb00-4695-a24a-8ad8a8fa5194',
 'timestamp': '2014-07-28 02:42:25.712147'}

wuyuting (wytdahu)
Changed in cinder:
assignee: nobody → wuyuting (wytdahu)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/110290

Changed in cinder:
assignee: wuyuting (wytdahu) → John Griffith (john-griffith)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on cinder (master)

Change abandoned by John Griffith (<email address hidden>) on branch: master
Review: https://review.openstack.org/110290
Reason: respin with the dependency

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/110351
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=5ee167c14c9978409db059054a02635de35a2e93
Submitter: Jenkins
Branch: master

commit 5ee167c14c9978409db059054a02635de35a2e93
Author: John Griffith <email address hidden>
Date: Tue Jul 29 09:59:33 2014 -0600

    Update ref used for notifications

    When we update a snapshot status in the db, we need to
    use the newly updated snapshot-ref object in the following
    notification method call. Otherwise we're sending a
    notifciation message with the old/outdated status
    information.

    NOTE: This also fixes the unit test that was written to
    pass with the bug that existed in the notification.

    Closes-Bug: #1349805

    Change-Id: I32b86d7edd836310c6da7adffa46e915361668f0

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in cinder:
milestone: none → juno-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: juno-3 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.