Volume detach will be attempted if volume stats is "in-use" OR attach_status is "attached"

[Ryan McNair]

In begin_detaching, the detach will be attempted if volume state is "in-use" OR attach_status is "attached" but the error message states that detach will only be attempted if volume state is "in-use" AND attach_status is "attached"

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/104445

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/104445
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=87cd23419bdd5724e742eda21bc23876b558e0d1
Submitter: Jenkins
Branch: master

commit 87cd23419bdd5724e742eda21bc23876b558e0d1
Author: Ryan McNair <email address hidden>
Date: Thu Jul 3 04:35:05 2014 +0000

    Fix begin_detach logic

    Fix begin_detach logic so it checks that a volume is in-use AND
    attached.

    Change-Id: I6f0e584070a5fc02c55c26ea92cb8b0c2a2cda3e
    Closes-Bug: #1337088