iSER transport protocol is Broken

Bug #1336648 reported by Nurit Vilosny
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Low
Nurit Vilosny
Icehouse
Fix Released
Undecided
Unassigned

Bug Description

when configuring ISER ( at /etc/cinder/cinder.conf: volume_driver=cinder.volume.drivers.lvm.LVMISERDriver)
volumes cannot be attached.
this happens also in Icehouse (stable).

i will add more logs soon.

Revision history for this message
Nurit Vilosny (nuritv) wrote :

attached logs.

Revision history for this message
Nurit Vilosny (nuritv) wrote :
Changed in cinder:
status: New → Confirmed
Nurit Vilosny (nuritv)
Changed in cinder:
assignee: nobody → nurit Vilosny (nuritv)
Nurit Vilosny (nuritv)
Changed in cinder:
status: Confirmed → In Progress
status: In Progress → Fix Committed
status: Fix Committed → In Progress
Revision history for this message
John Griffith (john-griffith) wrote :

Honestly I've been looking at this code recently and I'm not really sure how it could possibly work. Sounds like Nurit is working on it, I've also asked for somebody with ISER to take a look at:
https://review.openstack.org/#/c/107205/

Changed in cinder:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/110088

Nurit Vilosny (nuritv)
summary: - ISER dirver is broken
+ iSER transport protocol is Broken
Jay Bryant (jsbryant)
tags: added: drivers
Rushi Agrawal (rushiagr)
tags: added: icehouse-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/110088
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=f66f9e5805070e5ad2ba4688c6c4571ef1ec395a
Submitter: Jenkins
Branch: master

commit f66f9e5805070e5ad2ba4688c6c4571ef1ec395a
Author: nuritv <email address hidden>
Date: Mon Jul 28 21:50:55 2014 +0300

    fixing the iSER transport protocol when using LVMISERDriver

    ISER capabilities were broken in icehouse when trying to remove
    duplication between ISCSIDriver and ISERDriver.
    this fix does minimal changes in the code in order to fix
    the capability.
    the fix is basically re-adding the ISERTgtAdm and re-adding
    the support in LVMISERDriver: change target_lun based on
    iseradm.

    Closes-Bug: #1336648
    Change-Id: Ic3c9da9577d09d9199218ea82bda56599527223c

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in cinder:
milestone: none → juno-3
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (stable/icehouse)

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/125282

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/125687

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on cinder (stable/icehouse)

Change abandoned by Aviram Bar-Haim (<email address hidden>) on branch: stable/icehouse
Review: https://review.openstack.org/125282
Reason: New commit https://review.openstack.org/#/c/125687/1 with correct Change-ID and Hash

Thierry Carrez (ttx)
Changed in cinder:
milestone: juno-3 → 2014.2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (stable/icehouse)

Reviewed: https://review.openstack.org/125687
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=d57b3394ed06a52715f16ed378a07629143edd30
Submitter: Jenkins
Branch: stable/icehouse

commit d57b3394ed06a52715f16ed378a07629143edd30
Author: Aviram Bar-Haim <email address hidden>
Date: Tue Sep 30 18:26:01 2014 +0200

    fixing the iSER transport protocol when using LVMISERDriver

    ISER capabilities were broken in icehouse when trying to remove
    duplication between ISCSIDriver and ISERDriver.

    This fix does minimal changes in the code in order to fix
    the capability.

    The fix is basically re-adding the ISERTgtAdm and re-adding
    the support in LVMISERDriver: change target_lun based on
    iseradm.

    Conflicts:
            cinder/volume/driver.py

    Changes from the original fix in Juno:

    Bug https://bugs.launchpad.net/cinder/+bug/1325799
    caused the volumes to be created with iSCSI's prefix
    parameter in any case. In order to solve the prefix mismatch,
    iSER's prefix is updated to match iSCSI’s prefix.
    The related changes:
      1. cinder/brick/iscsi/iscsi.py line 614
      2. Cinder/volume/driver.py line 118
      3. etc/cinder/cinder.conf.sample line 921

    Closes-Bug: #1336648
    Change-Id: Ic3c9da9577d09d9199218ea82bda56599527223c
    (cherry picked from commit f66f9e5805070e5ad2ba4688c6c4571ef1ec395a)

tags: added: in-stable-icehouse
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.