Misuse of i18n log translation to output error message

Bug #1334334 reported by Mitsuhiro Tanino
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
Mitsuhiro Tanino

Bug Description

I found a misuse of i18n log translation for error message in "cinder/volume/drivers/lvm.py'.

The "%s' can not be translated. In this case, the "message' must be i18ning and then the "message" should be outputted using LOG.error.

I will fix this.

-----
@@ -573,9 +573,9 @@ class LVMISCSIDriver(LVMVolumeDriver, driver.ISCSIDriver):
             try:
                 (vg for vg in vg_list if vg['name'] == dest_vg).next()
             except StopIteration:
                message = ("Destination Volume Group %s does not exist" %
                            dest_vg)
                LOG.error(_('%s'), message)
                 return false_ret

             helper = utils.get_root_helper()

-----

description: updated
Changed in cinder:
assignee: nobody → Mitsuhiro Tanino (mitsuhiro-tanino)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/102615

Changed in cinder:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/102615
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=663eadfb2b7facbae7ba2cf6fe579355e1cc5e02
Submitter: Jenkins
Branch: master

commit 663eadfb2b7facbae7ba2cf6fe579355e1cc5e02
Author: Mitsuhiro Tanino <email address hidden>
Date: Tue Jun 24 19:40:36 2014 -0400

    Misuse of i18n log translation to output error message

    I found a misuse of i18n log translation for error message
    in "cinder/volume/drivers/lvm.py'.

    The "%s' can not be translated. In this case, the "message'
    must be i18ning and then the "message" should be output
    using LOG.error().

    Change-Id: I4495522d337764dc28186225f4594a227ac3e555
    Signed-off-by: Mitsuhiro Tanino <email address hidden>
    Closes-Bug: 1334334

Changed in cinder:
status: In Progress → Fix Committed
Changed in cinder:
milestone: none → juno-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: juno-2 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.