vmware: create volume from image fails if an eligible host is in a bad connection state

[Unmesh Gurjar]

Branch/Release: stable/havana

Pre-requisite:
Configure cinder to use VMDK driver and enable a backend with a vCenter having a host in a "not responding" state.

Steps to reproduce:
1. Create a VMDK volume specifying an image as the volume source.
2. Observe the volume status.

Actual behavior:
Volume creation fails with the error message "The operation is not allowed in the current connection state of the host" in cinder volume service logs.

Expected Behavior:
VMDK driver should handle the exception and try creating the volume on the next available host in the vCenter.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/97796

[Vipin Balachandran (vbala)]

The problem is with the exception hierarchy and it is fixed in master: https://review.openstack.org/#/c/87895/

Icehouse backport review (in progress): https://review.openstack.org/#/c/95651/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/97796
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=8e019824f3fc016e488e7e87839a071318b1ca43
Submitter: Jenkins
Branch: stable/havana

commit 8e019824f3fc016e488e7e87839a071318b1ca43
Author: Unmesh Gurjar <email address hidden>
Date: Wed Jun 4 19:38:04 2014 +0530

    vmware: Fixes create volume from image error

    While creating a volume with an image specified as the volume source,
    the VMDK driver tries creating the volume backing file on each host
    in the inventory (one by one; until any attempt succeeds). However,
    if the attempted host is in a bad connection state, the volume
    creation fails and results in the volume going into error state.
    Effectively, user cannot create a volume from image in such scenario.
    This patch catches the VimFaultException during backing file
    creation, so that driver picks the next available host for volume
    creation.

    Change-Id: I8ffdb849f41e8c28137ad8c0fa1f86c54b5e6fe9
    Closes-Bug: #1326366