cinder-volume-usage-audit doesn't work with rpc-based notifiers

[Ondergetekende]

2014-05-06 10:26:06.069 25238 ERROR cinder [req-9b9a7933-9aed-413c-bf8b-10233d4c93ee - - - - -] Failed to send exists notification for volume e554be99-e2cf-4236-a540-efef453d0f24.
Traceback (most recent call last):
  File "/usr/local/virtualenvs/cinder-api/bin/cinder-volume-usage-audit", line 125, in <module>
    'exists', extra_usage_info=extra_info)
  File "/usr/local/virtualenvs/cinder-api/local/lib/python2.7/site-packages/cinder/volume/utils.py", line 68, in notify_about_volume_usage
    rpc.get_notifier("volume", host).info(context, 'volume.%s' % event_suffix,
  File "/usr/local/virtualenvs/cinder-api/local/lib/python2.7/site-packages/cinder/rpc.py", line 149, in get_notifier
    assert NOTIFIER is not None
AssertionError

This is caused by cinder-volume-usage-audit not initializing RPC.

[Openstack Gerrit (openstack-gerrit)]

Fix proposed to branch: master
Review: https://review.openstack.org/92318

[Openstack Gerrit (openstack-gerrit)]

Reviewed: https://review.openstack.org/92318
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=e52445681400ff1f8a78a39dca07d4d9711dfe52
Submitter: Jenkins
Branch: master

commit e52445681400ff1f8a78a39dca07d4d9711dfe52
Author: Koert van der Veer <email address hidden>
Date: Tue May 6 11:04:00 2014 +0200

    Properly initialize rpc in cinder-volume-usage-audit

    When RPC isn't initialized, any RPC based notifiers will fail, which
    renders cinder-volume-usage-audit mostly useless.

    Change-Id: I0b2d63871c0e57f8a9a55059c5fa22dc785b2767
    Closes-Bug: #1316483

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/94121

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/94207

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/94207
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=41127fbb9b9c09369b72fecc7e8b439590f676a9
Submitter: Jenkins
Branch: stable/icehouse

commit 41127fbb9b9c09369b72fecc7e8b439590f676a9
Author: Koert van der Veer <email address hidden>
Date: Tue May 6 11:04:00 2014 +0200

    Properly initialize rpc in cinder-volume-usage-audit

    When RPC isn't initialized, any RPC based notifiers will fail, which
    renders cinder-volume-usage-audit mostly useless.

    Closes-Bug: #1316483
    (cherry picked from commit e52445681400ff1f8a78a39dca07d4d9711dfe52)

    Change-Id: Ib6b9b1fdc76f289e9a44de520eeccbf99e28f40b

[Sam Morrison (sorrison)]

I've applied this patch and now get a different error:

2014-06-03 14:45:11.997 27913 TRACE oslo.messaging.notify._impl_messaging Traceback (most recent call last):
2014-06-03 14:45:11.997 27913 TRACE oslo.messaging.notify._impl_messaging File "/usr/lib/python2.7/dist-packages/oslo/messaging/notify/_impl_messaging.py", line 47, in notify
2014-06-03 14:45:11.997 27913 TRACE oslo.messaging.notify._impl_messaging version=self.version)
2014-06-03 14:45:11.997 27913 TRACE oslo.messaging.notify._impl_messaging File "/usr/lib/python2.7/dist-packages/oslo/messaging/transport.py", line 96, in _send_notification
2014-06-03 14:45:11.997 27913 TRACE oslo.messaging.notify._impl_messaging self._driver.send_notification(target, ctxt, message, version)
2014-06-03 14:45:11.997 27913 TRACE oslo.messaging.notify._impl_messaging File "/usr/lib/python2.7/dist-packages/oslo/messaging/_drivers/amqpdriver.py", line 390, in send_notification
2014-06-03 14:45:11.997 27913 TRACE oslo.messaging.notify._impl_messaging envelope=(version == 2.0), notify=True)
2014-06-03 14:45:11.997 27913 TRACE oslo.messaging.notify._impl_messaging File "/usr/lib/python2.7/dist-packages/oslo/messaging/_drivers/amqpdriver.py", line 365, in _send
2014-06-03 14:45:11.997 27913 TRACE oslo.messaging.notify._impl_messaging with self._get_connection() as conn:
2014-06-03 14:45:11.997 27913 TRACE oslo.messaging.notify._impl_messaging File "/usr/lib/python2.7/dist-packages/oslo/messaging/_drivers/amqpdriver.py", line 315, in _get_connection
2014-06-03 14:45:11.997 27913 TRACE oslo.messaging.notify._impl_messaging pooled=pooled)
2014-06-03 14:45:11.997 27913 TRACE oslo.messaging.notify._impl_messaging File "/usr/lib/python2.7/dist-packages/oslo/messaging/_drivers/amqp.py", line 122, in __init__
2014-06-03 14:45:11.997 27913 TRACE oslo.messaging.notify._impl_messaging self.connection = connection_pool.get()
2014-06-03 14:45:11.997 27913 TRACE oslo.messaging.notify._impl_messaging File "/usr/lib/python2.7/dist-packages/oslo/messaging/_drivers/pool.py", line 71, in get
2014-06-03 14:45:11.997 27913 TRACE oslo.messaging.notify._impl_messaging return self.create()
2014-06-03 14:45:11.997 27913 TRACE oslo.messaging.notify._impl_messaging File "/usr/lib/python2.7/dist-packages/oslo/messaging/_drivers/amqp.py", line 72, in create
2014-06-03 14:45:11.997 27913 TRACE oslo.messaging.notify._impl_messaging return self.connection_cls(self.conf, self.url)
2014-06-03 14:45:11.997 27913 TRACE oslo.messaging.notify._impl_messaging File "/usr/lib/python2.7/dist-packages/oslo/messaging/_drivers/impl_rabbit.py", line 492, in __init__
2014-06-03 14:45:11.997 27913 TRACE oslo.messaging.notify._impl_messaging self.reconnect()
2014-06-03 14:45:11.997 27913 TRACE oslo.messaging.notify._impl_messaging File "/usr/lib/python2.7/dist-packages/oslo/messaging/_drivers/impl_rabbit.py", line 595, in reconnect
2014-06-03 14:45:11.997 27913 TRACE oslo.messaging.notify._impl_messaging self._connect(broker)
2014-06-03 14:45:11.997 27913 TRACE oslo.messaging.notify._impl_messaging File "/usr/lib/python2.7/dist-packages/oslo/messaging/_drivers/impl_rabbit.py", line 571, in _co...