quota-update should error out if input provided is non-existent tenant id

Bug #1307491 reported by Tushar Bankar on 2014-04-14
38
This bug affects 7 people
Affects Status Importance Assigned to Milestone
Cinder
Low
Unassigned

Bug Description

cinder quota-update non-existent-tenant --gigabytes 2

cinder returns 200 (OK).

It is expected to return 404 if tenant does not exists.

Changed in cinder:
assignee: nobody → Tushar Bankar (tushar-bankar)
tags: added: izeltech
Eric Harney (eharney) on 2014-04-15
tags: removed: izeltech
Mike Perez (thingee) on 2014-04-15
Changed in cinder:
status: New → Triaged
Changed in cinder:
assignee: Tushar Bankar (tushar-bankar) → Harshada Mangesh Kakad (harshada-kakad)

Fix proposed to branch: master
Review: https://review.openstack.org/95464

Changed in cinder:
status: Triaged → In Progress
summary: - quota-update should error out if input provided is wrong tenant id
+ quota-update should error out if input provided is non-existent tenant
+ id
description: updated
Huang Zhiteng (zhiteng-huang) wrote :

I'm not a HTTP expert, but I think 404 response is for HTTP GET request. Quota update is a POST request, I am not sure 404 is 'expected' result of non-existent tenant.

Mike Perez (thingee) wrote :

I think we return 404 for reasons like this already.

Duncan Thomas (duncan-thomas) wrote :

I think this came up before, and there is no way to validate the tenant... e.g. do a quota update for a tenant that currently has default quota (i.e. no tenant specific db entry). Cinder would have to call keystone to validate the tenant, which (a) last time this came up a suitable keystone call was not found (b) requires a blocking call to keystone in our API code to get the behaviour above, which is something we try to avoid

Duncan Thomas (duncan-thomas) wrote :

More useful comments added to the review

Change abandoned by Duncan Thomas (<email address hidden>) on branch: master
Review: https://review.openstack.org/95464
Reason: Abandoning change: No update for more than 14 days

Fix proposed to branch: master
Review: https://review.openstack.org/143645

Changed in cinder:
assignee: Harshada Mangesh Kakad (harshada-kakad) → Anton Arefiev (aarefiev)
Jay Bryant (jsbryant) on 2014-12-23
Changed in cinder:
importance: Undecided → Medium
Mike Perez (thingee) on 2015-01-02
Changed in cinder:
milestone: none → kilo-2
Mike Perez (thingee) on 2015-02-02
Changed in cinder:
milestone: kilo-2 → kilo-3
Mike Perez (thingee) wrote :

Retargeting this. Duncan has objections and we're out of time in Kilo.

Changed in cinder:
milestone: kilo-3 → liberty-1
Vilobh Meshram (vilobhmm) wrote :

Anton Arefiev : Are you actively working on this Bug if not I can take it up and fix it.

Mike Perez (thingee) on 2015-06-17
Changed in cinder:
milestone: liberty-1 → liberty-2
Changed in cinder:
assignee: Anton Arefiev (aarefiev) → Duncan Thomas (duncan-thomas)
Changed in cinder:
assignee: Duncan Thomas (duncan-thomas) → Anton Arefiev (aarefiev)
Changed in cinder:
assignee: Anton Arefiev (aarefiev) → John Griffith (john-griffith)
stasis (rafael-galarza) wrote :

This bug also seems to apply to cinder quota-defaults

Mike Perez (thingee) on 2015-07-28
Changed in cinder:
milestone: liberty-2 → liberty-3

Change abandoned by Anton Arefiev (<email address hidden>) on branch: master
Review: https://review.openstack.org/143645
Reason: More general approach is needed here

Changed in cinder:
milestone: liberty-3 → none
assignee: John Griffith (john-griffith) → nobody
importance: Medium → Low
Robin Naundorf (senk) on 2016-04-28
Changed in cinder:
status: In Progress → Confirmed
haobing1 (haobing1) on 2016-09-05
Changed in cinder:
assignee: nobody → haobing1 (haobing1)

Unassigning due to no activity.

Changed in cinder:
assignee: haobing1 (haobing1) → nobody
Xu Ao (xuao) on 2017-03-30
Changed in cinder:
assignee: nobody → Xu Ao (xuao)

Unassigning due to no activity for > 6 months.

Changed in cinder:
assignee: Xu Ao (xuao) → nobody
Changed in cinder:
assignee: nobody → Tejaswini Grandhe (grantejaswini)
Changed in cinder:
assignee: Tejaswini Grandhe (grantejaswini) → nobody
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers