Cinder

Cinder fails to associate targets to initiators on Windows

Bug #1299131 reported by Lucian Petrut
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
High
Lucian Petrut
Cinder 2014.1 "icehouse"

Bug Description

Due to a small nit, the initiator name and the target name are inverted when passing the arguments to the method which associates the iSCSI target to an initiator. For this reason, this operation will fail.

The connection to the iSCSI target cannot be initialized properly as the method which gets portal information is missing the return value.

https://github.com/openstack/cinder/blob/master/cinder/volume/drivers/windows/windows.py#L71-72

Trace: http://paste.openstack.org/show/74581/

Lucian Petrut (petrutlucian94)
summary: - Cinder fails to associate targets to initiators
+ Cinder fails to associate targets to initiators on Windows
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/83864

Changed in cinder:
assignee: nobody → Petrut Lucian (petrutlucian94)
status: New → In Progress
John Griffith (john-griffith)
tags: added: drivers icehouse-backport-potential windows
Changed in cinder:
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/83864
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=23e820abb8685573f97f5e3764225a97dd695127
Submitter: Jenkins
Branch: master

commit 23e820abb8685573f97f5e3764225a97dd695127
Author: Lucian Petrut <email address hidden>
Date: Fri Mar 28 10:57:13 2014 +0200

    Fixes cinder volume attach on Windows

    The initiator name and the target name are inverted when passing
    the arguments to the method which associates the iSCSI target to
    an initiator. For this reason, this operation will fail.

    Also, the connection to the iSCSI target cannot be initialized
    properly as the method which gets portal information is missing
    the return value.

    Change-Id: I31034cd407d12d69a410f8c9e86a2e6821349dad
    Closes-Bug: #1299131

Changed in cinder:
status: In Progress → Fix Committed
John Griffith (john-griffith)
tags: added: icehouse-rc-potential
removed: icehouse-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (milestone-proposed)

Fix proposed to branch: milestone-proposed
Review: https://review.openstack.org/84552

Thierry Carrez (ttx)
Changed in cinder:
milestone: none → icehouse-rc2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (milestone-proposed)

Reviewed: https://review.openstack.org/84552
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=3ac21395002531f0da35cc7083b31c3219179519
Submitter: Jenkins
Branch: milestone-proposed

commit 3ac21395002531f0da35cc7083b31c3219179519
Author: Lucian Petrut <email address hidden>
Date: Fri Mar 28 10:57:13 2014 +0200

    Fixes cinder volume attach on Windows

    The initiator name and the target name are inverted when passing
    the arguments to the method which associates the iSCSI target to
    an initiator. For this reason, this operation will fail.

    Also, the connection to the iSCSI target cannot be initialized
    properly as the method which gets portal information is missing
    the return value.

    Change-Id: I31034cd407d12d69a410f8c9e86a2e6821349dad
    Closes-Bug: #1299131
    (cherry picked from commit 23e820abb8685573f97f5e3764225a97dd695127)

Changed in cinder:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: icehouse-rc2 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.