Cinder

Cinder fails to delete volumes on Windows

Bug #1299124 reported by Lucian Petrut
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
High
Lucian Petrut
Cinder 2014.1 "icehouse"

Bug Description

This commit https://github.com/openstack/cinder/commit/beecd769af02ba5915be827d28a7b46d970e41b0 has changed the flow of volume creation, so Cinder does not create an iSCSI target anymore when a volume is created. Even so, the Windows Cinder driver tries to remove the according iSCSI target every time a volume is deleted, resulting into an error when the target has not been created. The fix consists in checking if the target exists before attempting to delete it.

Trace: http://paste.openstack.org/show/73912/

See original description
Lucian Petrut (petrutlucian94)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/83857

Changed in cinder:
assignee: nobody → Petrut Lucian (petrutlucian94)
status: New → In Progress
John Griffith (john-griffith)
tags: added: drivers icehouse-backport-potential windows
Changed in cinder:
importance: Undecided → High
John Griffith (john-griffith)
tags: added: icehouse-rc-potential
removed: icehouse-backport-potential
Revision history for this message
Mike Perez (thingee) wrote :

Your trace is the same as the mentioned commit. Can you paste the real link to the trace?

Revision history for this message
Lucian Petrut (petrutlucian94) wrote :

Whops, sorry for this. I haven't seen that. Thanks.

description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/83857
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=601d54c9ef926fa2d8abfe0121019f7ad94eefd5
Submitter: Jenkins
Branch: master

commit 601d54c9ef926fa2d8abfe0121019f7ad94eefd5
Author: Lucian Petrut <email address hidden>
Date: Fri Mar 28 10:47:07 2014 +0200

    Fixes cinder volume delete on Windows

    Because of the fact that an iSCSI target is not created anymore
    at volume creation time, not all volumes will have a corresponding
    target. For this reason, when removing an iSCSI target we must
    first check if the target actually exists.

    Change-Id: I8e571397df6d9a2eeb05e883b7da8494d4bfa1ad
    Closes-Bug: #1299124

Changed in cinder:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (milestone-proposed)

Fix proposed to branch: milestone-proposed
Review: https://review.openstack.org/85369

John Griffith (john-griffith)
Changed in cinder:
milestone: none → icehouse-rc2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (milestone-proposed)

Reviewed: https://review.openstack.org/85369
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=c70d356352ee21b102a33e0b84928419894ed3c8
Submitter: Jenkins
Branch: milestone-proposed

commit c70d356352ee21b102a33e0b84928419894ed3c8
Author: Lucian Petrut <email address hidden>
Date: Fri Mar 28 10:47:07 2014 +0200

    Fixes cinder volume delete on Windows

    Because of the fact that an iSCSI target is not created anymore
    at volume creation time, not all volumes will have a corresponding
    target. For this reason, when removing an iSCSI target we must
    first check if the target actually exists.

    Change-Id: I8e571397df6d9a2eeb05e883b7da8494d4bfa1ad
    Closes-Bug: #1299124
    (cherry picked from commit 601d54c9ef926fa2d8abfe0121019f7ad94eefd5)

Changed in cinder:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: icehouse-rc2 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.