Image stuck in "Queued" state on upload to image failure

Bug #1298042 reported by Ryan Hsu
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Medium
Vipin Balachandran

Bug Description

When uploading a volume to an image with an unsupported disk type (anything other than vmdk), an orphan image stuck in "Queued" state gets left behind.

Steps to reproduce:

1. cinder create 1
2. cinder upload-to-image --disk raw <volume id> <name>

The result is an orphan image in Glance that gets left behind. This image should not exist.

Changed in cinder:
status: New → Confirmed
importance: Undecided → Medium
assignee: nobody → Vipin Balachandran (vbala)
milestone: none → next
Revision history for this message
Vipin Balachandran (vbala) wrote :

The image status is always set outside the driver. Therefore, it doesn't seem appropriate for the driver to change the status or delete the image on errors during copy.

Changed in cinder:
assignee: Vipin Balachandran (vbala) → nobody
summary: - VMware: Image stuck in "Queued" if uploaded to image with incorrect disk
- type
+ Image stuck in "Queued" state on upload to image failure
tags: removed: drivers vmware
Changed in cinder:
assignee: nobody → Vipin Balachandran (vbala)
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/91775

Changed in cinder:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/91775
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=31569827c749dca6e0affd4646360b839f321758
Submitter: Jenkins
Branch: master

commit 31569827c749dca6e0affd4646360b839f321758
Author: Vipin Balachandran <email address hidden>
Date: Wed Apr 30 17:30:57 2014 +0530

    Delete image on upload-to-image failure

    On upload-to-image failure before initiating the data transfer or during
    data transfer, the source volume status is restored properly whereas the
    image created remains in queued or saving state. This change deletes the
    image during such failures.

    Change-Id: I0aa64798d2bc5bf19b79dd3b88dcd107ff369c42
    Closes-Bug: #1298042

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in cinder:
milestone: next → none
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.