"SIS clone not licensed" error is confusing

[Glenn M. Gobeli]

Customers don't know what SIS clone is when an error of "SIS clone not licensed." is returned on a cloning operation. The NetApp cinder driver should refer to the license by its correct name: "FlexClone".

[Glenn M. Gobeli (ggobeli)]

More investigation shows that ONTAP will use the "SIS clone not licensed" when the "clone-start" interface is invoked. This happens in the clone_volume, create_volume_from_snapshot, create_snapshot, etc. methods. We can catch this error and modify to use the correct license name.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/82099

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/82099
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=9920eb9edc9707270e20a9286774f20f95fc7cca
Submitter: Jenkins
Branch: master

commit 9920eb9edc9707270e20a9286774f20f95fc7cca
Author: Glenn M. Gobeli <email address hidden>
Date: Fri Mar 21 10:05:07 2014 -0400

    Changes to correct name of missing NetApp license.

    Change to have the NetApp ZAPI error of "SIS clone not licensed"
    refer to the correct NetApp license of "FlexClone not licensed".
    This code path is encountered when the NetApp 7mode driver uses
    the clone interface for snapshotting or cloning.

    Change-Id: I3e4d07d38870928a324ad044e03938826b0d0a98
    Closes-Bug: #1295349