NFS driver does not implement extend volume

Bug #1295316 reported by Andrew Kerr
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Medium
Andrew Kerr

Bug Description

The generic NFS driver does not implement the volume extend feature.

2014-03-20 14:54:01.770 ERROR cinder.volume.manager [req-49a0fce4-c244-47c6-8d15-1c78b43bc4b5 394190ae53024d4db21ad36889ee49fb 8305968860c84220991ffb2926794286] volume f925db6e-2454-4d74-85fb-8986684c55ba: Error trying to extend volume
2014-03-20 14:54:01.770 TRACE cinder.volume.manager Traceback (most recent call last):
2014-03-20 14:54:01.770 TRACE cinder.volume.manager File "/opt/stack/cinder/cinder/volume/manager.py", line 1145, in extend_volume
2014-03-20 14:54:01.770 TRACE cinder.volume.manager self.driver.extend_volume(volume, new_size)
2014-03-20 14:54:01.770 TRACE cinder.volume.manager File "/opt/stack/cinder/cinder/volume/driver.py", line 530, in extend_volume
2014-03-20 14:54:01.770 TRACE cinder.volume.manager raise NotImplementedError(msg)
2014-03-20 14:54:01.770 TRACE cinder.volume.manager NotImplementedError: Extend volume not implemented
2014-03-20 14:54:01.770 TRACE cinder.volume.manager

Tags: nfs
Changed in cinder:
status: New → Confirmed
importance: Undecided → Medium
milestone: none → next
Revision history for this message
AllenGuo (xiaoguo) wrote :

@John Griffith
Hi,
One simple way to implement extend_volume in NFS driver is using truncate,
but I am not sure if this a good practice.
any idea?

Changed in cinder:
assignee: nobody → AllenGuo (xiaoguo)
Revision history for this message
Navneet (singn) wrote :

Allen the easiest way to fix this would be by shifting the extend_volume/dependent methods in NetAppNFSDriver to NfsDriver. It uses image_utils and subsequently qemu to extend the volume. Truncate is another way to abruptly increase the size of a file but the former takes care of any block device format/file systems on it.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/82100

Changed in cinder:
assignee: AllenGuo (xiaoguo) → Andrew Kerr (andrew-kerr)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/82100
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=8cd4224070299cefa922ff2251fe81770494ad46
Submitter: Jenkins
Branch: master

commit 8cd4224070299cefa922ff2251fe81770494ad46
Author: Andrew Kerr <email address hidden>
Date: Fri Mar 21 10:13:58 2014 -0400

    Implement extend volume in NFS driver

    This fix implements the extend_volume functionality in the NFS
    driver.

    Change-Id: I1634fef0206b4ef12684c6c7f4851d76da579942
    Closes-Bug: #1295316

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in cinder:
milestone: next → none
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.